From 77552d63803cbad4d98fa4d72a5d09d63c1d24fb Mon Sep 17 00:00:00 2001
From: Gabriel Wicke <gwicke@users.mediawiki.org>
Date: Fri, 24 Mar 2006 16:48:10 +0000
Subject: [PATCH] Don't place html in alt/title attributes, especially with
 thumbnails

---
 includes/Parser.php | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/includes/Parser.php b/includes/Parser.php
index 4329bd180d..00dfae2808 100644
--- a/includes/Parser.php
+++ b/includes/Parser.php
@@ -3173,6 +3173,13 @@ class Parser
 		$valid = '0123456789-Xx';
 
 		foreach ( $a as $x ) {
+			# hack: don't replace inside thumbnail title/alt
+			# attributes
+			if(preg_match('/<[^>]+(alt|title)="[^">]*$/', $text)) {
+				$text .= "ISBN $x";
+				continue;
+			}
+
 			$isbn = $blank = '' ;
 			while ( ' ' == $x{0} ) {
 				$blank .= ' ';
@@ -3195,7 +3202,7 @@ class Parser
 			} else {
 				$titleObj = Title::makeTitle( NS_SPECIAL, 'Booksources' );
 				$text .= '<a href="' .
-				$titleObj->escapeLocalUrl( 'isbn='.$num ) .
+					$titleObj->escapeLocalUrl( 'isbn='.$num ) .
 					"\" class=\"internal\">ISBN $isbn</a>";
 				$text .= $x;
 			}
@@ -3239,6 +3246,13 @@ class Parser
 				continue;
 				}
 
+			# hack: don't replace inside thumbnail title/alt
+			# attributes
+			if(preg_match('/<[^>]+(alt|title)="[^">]*$/', $text)) {
+				$text .= $keyword . $x;
+				continue;
+			}
+			
 			$id = $blank = '' ;
 
 			/** remove and save whitespaces in $blank */
@@ -3824,6 +3838,11 @@ class Parser
 		}
 		# Strip bad stuff out of the alt text
 		$alt = $this->replaceLinkHoldersText( $caption );
+
+		# make sure there are no placeholders in thumbnail attributes
+		# that are later expanded to html- so expand them now and
+		# remove the tags
+		$alt = $this->unstrip($alt, $this->mStripState); 
 		$alt = Sanitizer::stripAllTags( $alt );
 
 		# Linker does the rest
-- 
2.20.1