From 732e3f12712016b2b3099ea1eb625f9dd1b59163 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Wed, 6 Jul 2011 17:52:27 +0000 Subject: [PATCH] Remove notes about being destructive. We work properly on cloned tables now --- tests/phpunit/TODO | 5 ----- tests/phpunit/includes/ArticleTablesTest.php | 1 - tests/phpunit/includes/api/ApiBlockTest.php | 1 - tests/phpunit/includes/api/ApiTest.php | 1 - tests/phpunit/includes/api/ApiUploadTest.php | 2 -- tests/phpunit/includes/api/ApiWatchTest.php | 1 - 6 files changed, 11 deletions(-) diff --git a/tests/phpunit/TODO b/tests/phpunit/TODO index 76f38c1dcc..b2fa7fb6af 100644 --- a/tests/phpunit/TODO +++ b/tests/phpunit/TODO @@ -1,9 +1,4 @@ == Things To Do == - -* DEFAULT TESTS NEED TO MADE NON-DESTRUCTIVE. Any destructive tests which alter the contents of the live wiki need to -be protected with an explicit confirmation so people exploring their system don't accidentally destroy their main page -or register user accounts with default passwords. - * Most of the tests are named poorly; naming should describe a use case in story-like language, not simply identify the unit under test. An example would be the difference between testCalculate and testAddingIntegersTogetherWorks. * Many of the tests make multiple assertions, and are thus not unitary tests. By using data-providers and more use-case diff --git a/tests/phpunit/includes/ArticleTablesTest.php b/tests/phpunit/includes/ArticleTablesTest.php index 362cddf9a6..01776c9590 100644 --- a/tests/phpunit/includes/ArticleTablesTest.php +++ b/tests/phpunit/includes/ArticleTablesTest.php @@ -2,7 +2,6 @@ /** * @group Database - * @group Destructive */ class ArticleTablesTest extends MediaWikiLangTestCase { diff --git a/tests/phpunit/includes/api/ApiBlockTest.php b/tests/phpunit/includes/api/ApiBlockTest.php index 325a30f1fb..227555ebf1 100644 --- a/tests/phpunit/includes/api/ApiBlockTest.php +++ b/tests/phpunit/includes/api/ApiBlockTest.php @@ -2,7 +2,6 @@ /** * @group Database - * @group Destructive */ class ApiBlockTest extends ApiTestCase { diff --git a/tests/phpunit/includes/api/ApiTest.php b/tests/phpunit/includes/api/ApiTest.php index e2215ac447..a587e6b19f 100644 --- a/tests/phpunit/includes/api/ApiTest.php +++ b/tests/phpunit/includes/api/ApiTest.php @@ -2,7 +2,6 @@ /** * @group Database - * @group Destructive */ class ApiTest extends ApiTestCase { diff --git a/tests/phpunit/includes/api/ApiUploadTest.php b/tests/phpunit/includes/api/ApiUploadTest.php index 8ce625813e..e2a31503d7 100644 --- a/tests/phpunit/includes/api/ApiUploadTest.php +++ b/tests/phpunit/includes/api/ApiUploadTest.php @@ -2,7 +2,6 @@ /** * @group Database - * @group Destructive */ /** @@ -20,7 +19,6 @@ require_once( 'ApiTestCaseUpload.php' ); /** * @group Database - * @group Destructive * * This is pretty sucky... needs to be prettified. */ diff --git a/tests/phpunit/includes/api/ApiWatchTest.php b/tests/phpunit/includes/api/ApiWatchTest.php index 7fca538698..3c7ff3040e 100644 --- a/tests/phpunit/includes/api/ApiWatchTest.php +++ b/tests/phpunit/includes/api/ApiWatchTest.php @@ -2,7 +2,6 @@ /** * @group Database - * @group Destructive * @todo This test suite is severly broken and need a full review */ class ApiWatchTest extends ApiTestCase { -- 2.20.1