From 54ebc9c5900bbaf49a2054a8742cda2a1d0da912 Mon Sep 17 00:00:00 2001
From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Thu, 11 Jun 2009 10:49:33 +0000
Subject: [PATCH] Fix for r51667: external diff is also controlled by
 $wgUseExternalEditor (see includes/diff/DifferenceEngine.php line 107).
 $wgExternalDiffEngine is used to change the difference engine's backend
 (wikidiff, wikidiff2, ...) and not to allow users to have their own
 difference engine.

---
 includes/Preferences.php | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/includes/Preferences.php b/includes/Preferences.php
index 0bc07964ab..b5c3c01f50 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -574,6 +574,8 @@ class Preferences {
 	}
 	
 	static function editingPreferences( $user, &$defaultPreferences ) {
+		global $wgUseExternalEditor;
+
 		## Editing #####################################
 		$defaultPreferences['cols'] =
 				array(
@@ -640,19 +642,14 @@ class Preferences {
 					'label-message' => 'tog-minordefault',
 				);
 
-		global $wgUseExternalEditor;
-		if ($wgUseExternalEditor) {
+		if ( $wgUseExternalEditor ) {
 			$defaultPreferences['externaleditor'] =
 					array(
 						'type' => 'toggle',
 						'section' => 'editing/advancedediting',
 						'label-message' => 'tog-externaleditor',
 					);
-		}
-
-		global $wgExternalDiffEngine;
-		if ($wgExternalDiffEngine) {
-		  $defaultPreferences['externaldiff'] =
+			$defaultPreferences['externaldiff'] =
 					array(
 						'type' => 'toggle',
 						'section' => 'editing/advancedediting',
-- 
2.20.1