From 4f616c3040acc4ccd8ae4b28b698784cc1dee100 Mon Sep 17 00:00:00 2001 From: addshore Date: Tue, 22 Mar 2016 12:26:59 +0000 Subject: [PATCH] Explicitly mark SkinTemplate properties as public As these are not actually defined in the class but are used they are effectively public. There are extensions that use at least 1 of these. The correct way forward is to now explicitly add them as public and then deprecate and remove in the future when needed. Change-Id: I287579135e29f70437f7e0777fe3dfe524af402e --- includes/skins/SkinTemplate.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php index 419c4b4653..5777076cc2 100644 --- a/includes/skins/SkinTemplate.php +++ b/includes/skins/SkinTemplate.php @@ -45,6 +45,14 @@ class SkinTemplate extends Skin { */ public $template = 'QuickTemplate'; + public $thispage; + public $titletxt; + public $userpage; + public $thisquery; + public $loggedin; + public $username; + public $userpageUrlDetails; + /** * Add specific styles for this skin * -- 2.20.1