From 15fb994130f5819ecbd14446f1c4ba51d71b6419 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Mon, 3 Jul 2017 09:13:09 +0200 Subject: [PATCH] Avoid double HTML encoding Html:element() already makes an HTML encoding. The additional htmlspecialchars is not necessary. Change-Id: If0530c3d3cb0d3cc61e849a1c84ae0d68c242517 --- includes/exception/MWExceptionRenderer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/exception/MWExceptionRenderer.php b/includes/exception/MWExceptionRenderer.php index 579b6ca666..2eb821ae69 100644 --- a/includes/exception/MWExceptionRenderer.php +++ b/includes/exception/MWExceptionRenderer.php @@ -305,7 +305,7 @@ class MWExceptionRenderer { if ( $wgShowHostnames || $wgShowSQLErrors ) { $info = str_replace( '$1', - Html::element( 'span', [ 'dir' => 'ltr' ], htmlspecialchars( $e->getMessage() ) ), + Html::element( 'span', [ 'dir' => 'ltr' ], $e->getMessage() ), htmlspecialchars( self::msg( 'dberr-info', '($1)' ) ) ); } else { -- 2.20.1