From 14c43476c668f32720ca51abb7def8a648c6fee2 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Sat, 12 Feb 2011 23:41:28 +0000 Subject: [PATCH] Never serve 304s from RL in debug mode. This causes inadvertent caching of debug responses --- includes/resourceloader/ResourceLoader.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php index 3d09b26d7a..3df06e2682 100644 --- a/includes/resourceloader/ResourceLoader.php +++ b/includes/resourceloader/ResourceLoader.php @@ -381,7 +381,8 @@ class ResourceLoader { // Some clients send "timestamp;length=123". Strip the part after the first ';' // so we get a valid timestamp. $ims = $context->getRequest()->getHeader( 'If-Modified-Since' ); - if ( $ims !== false ) { + // Never send 304s in debug mode + if ( $ims !== false && !$context->getDebug() ) { $imsTS = strtok( $ims, ';' ); if ( $mtime <= wfTimestamp( TS_UNIX, $imsTS ) ) { // There's another bug in ob_gzhandler (see also the comment at -- 2.20.1