lhc/web/wiklou.git
13 years agoFollow up r73951
Platonides [Wed, 29 Sep 2010 20:24:38 +0000 (20:24 +0000)]
Follow up r73951

13 years agoFix IEFixes.js loading again
Aryeh Gregor [Wed, 29 Sep 2010 20:05:16 +0000 (20:05 +0000)]
Fix IEFixes.js loading again

Bug 25167.  The fix in r65774 was wrong -- apparently I didn't test well
enough.  I've tested the new fix by loading IE6 and requesting a page
from my wiki without it, verifying with Wireshark that no HTTP request
was sent for IEFixes.js, and then repeating with the fix applied to
verify it works.

Will backport to 1.16, like r65774, since this is still a regression
from 1.15.  Note that only IE6 and less were ever affected, and things
seem to be mostly usable without the fixes file, so I don't think this
is of enormous importance.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Wed, 29 Sep 2010 20:04:42 +0000 (20:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-29 19:56:00 UTC)

13 years agoImplements bug 24343 "localurl discards section id".
Antoine Musso [Wed, 29 Sep 2010 19:51:48 +0000 (19:51 +0000)]
Implements bug 24343 "localurl discards section id".
* parser hook 'linkurl' which use Title::getLinkUrl()
* very basic tests for the Title class

13 years agoUpdated hooks documentation as per changes in r73971.
Trevor Parscal [Wed, 29 Sep 2010 19:06:32 +0000 (19:06 +0000)]
Updated hooks documentation as per changes in r73971.

13 years agoMade ResourceLoader an instantiable object, rather than a static one, making it more...
Trevor Parscal [Wed, 29 Sep 2010 19:04:04 +0000 (19:04 +0000)]
Made ResourceLoader an instantiable object, rather than a static one, making it more modular and testable.

13 years agoMove 'no license' further down the list. We want people to freely license their work...
Chad Horohoe [Wed, 29 Sep 2010 18:48:05 +0000 (18:48 +0000)]
Move 'no license' further down the list. We want people to freely license their work! Pointed out by vimpulse on IRC

13 years agoMove doApiRequest() up a level so ApiTest can use it as well. Fix first two tests...
Chad Horohoe [Wed, 29 Sep 2010 18:19:03 +0000 (18:19 +0000)]
Move doApiRequest() up a level so ApiTest can use it as well. Fix first two tests to do internal FauxRequests rather than relying on an external HTTP connection

13 years agoDocument return values I needed
Chad Horohoe [Wed, 29 Sep 2010 18:18:07 +0000 (18:18 +0000)]
Document return values I needed

13 years agoAdded support for PHPUnit 3.5, where PHPUnit_Util_Timer is replaced with PHP_Timer.
Trevor Parscal [Wed, 29 Sep 2010 18:02:56 +0000 (18:02 +0000)]
Added support for PHPUnit 3.5, where PHPUnit_Util_Timer is replaced with PHP_Timer.

13 years agoMark test incomplete if Main Page only has one author like on my install
Chad Horohoe [Wed, 29 Sep 2010 17:39:06 +0000 (17:39 +0000)]
Mark test incomplete if Main Page only has one author like on my install

13 years agofixing per comments at r70517
Ryan Kaldari [Wed, 29 Sep 2010 17:25:17 +0000 (17:25 +0000)]
fixing per comments at r70517

13 years agoRemove bogus addGroup() call. All users are in *
Chad Horohoe [Wed, 29 Sep 2010 16:26:24 +0000 (16:26 +0000)]
Remove bogus addGroup() call. All users are in *

13 years agoFixed dummy test that only checks that the License object can be created.
Platonides [Wed, 29 Sep 2010 16:20:41 +0000 (16:20 +0000)]
Fixed dummy test that only checks that the License object can be created.

13 years agoMove some globals into the class.
Platonides [Wed, 29 Sep 2010 16:05:46 +0000 (16:05 +0000)]
Move some globals into the class.

13 years agoTiny changes, fix comment, remove unused globals and throw and exception instead...
Platonides [Wed, 29 Sep 2010 15:54:43 +0000 (15:54 +0000)]
Tiny changes, fix comment, remove unused globals and throw and exception instead of a fatal if given a wrong langcode.

13 years agoRemove $wgServerName. Its only usage was for {{servername}}, and needed to be kept...
Platonides [Wed, 29 Sep 2010 15:47:56 +0000 (15:47 +0000)]
Remove $wgServerName. Its only usage was for {{servername}}, and needed to be kept in sync with $wgServer in LocalSettings.
None of the 3 globals based on it changed if you set it in LocalSettings.

Note that all those !isset( $wgServerName ) in ApiTests were useless, since if not in LocalSettings it would be 'localhost', not null (as still are those !isset( $wgServer )).

13 years agoFight PHP Fatal error: Call to a member function attributes() on a non-object
Platonides [Wed, 29 Sep 2010 15:22:47 +0000 (15:22 +0000)]
Fight PHP Fatal error:  Call to a member function attributes() on a non-object

13 years agoRevert r73887. I blame Nikerabbit!
Max Semenik [Wed, 29 Sep 2010 12:09:55 +0000 (12:09 +0000)]
Revert r73887. I blame Nikerabbit!

13 years agoFixed a few parser tests that were failing for me when run by PHPUnit
Max Semenik [Wed, 29 Sep 2010 09:05:47 +0000 (09:05 +0000)]
Fixed a few parser tests that were failing for me when run by PHPUnit

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Tue, 28 Sep 2010 19:02:58 +0000 (19:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-28 18:52:00 UTC)

13 years agoRewrite messenging for old message deletion. The old one is boring.
Antoine Musso [Tue, 28 Sep 2010 18:44:25 +0000 (18:44 +0000)]
Rewrite messenging for old message deletion. The old one is boring.

13 years agoUnify setUp/tearDown in ApiSetup, rather than duplicating in ApiWatchTest. Also fix...
Chad Horohoe [Tue, 28 Sep 2010 18:13:42 +0000 (18:13 +0000)]
Unify setUp/tearDown in ApiSetup, rather than duplicating in ApiWatchTest. Also fix some errors with not passing an array reference that were being suppressed (but silently work, yay PHP)

13 years agoFollowup r64181, rm comment that doesn't fit anymore
Chad Horohoe [Tue, 28 Sep 2010 17:10:51 +0000 (17:10 +0000)]
Followup r64181, rm comment that doesn't fit anymore

13 years agoUse suite user/password rather than assuming WikiSysop
Chad Horohoe [Tue, 28 Sep 2010 17:08:57 +0000 (17:08 +0000)]
Use suite user/password rather than assuming WikiSysop

13 years agoRevert r73879 for now, not ready yet.
Niklas Laxström [Tue, 28 Sep 2010 15:58:53 +0000 (15:58 +0000)]
Revert r73879 for now, not ready yet.

13 years agoFollowup r73884, remove unused file (obsoleted in r68544)
Chad Horohoe [Tue, 28 Sep 2010 15:53:24 +0000 (15:53 +0000)]
Followup r73884, remove unused file (obsoleted in r68544)

13 years agoFollowup r73880, forgot to give kbd and samp their attribute whitelists
Chad Horohoe [Tue, 28 Sep 2010 15:41:55 +0000 (15:41 +0000)]
Followup r73880, forgot to give kbd and samp their attribute whitelists

13 years agoDatabaseSqlite: better check for error. Noticed by Nikerabbit
Max Semenik [Tue, 28 Sep 2010 13:46:23 +0000 (13:46 +0000)]
DatabaseSqlite: better check for error. Noticed by Nikerabbit

13 years agoMove parser test related stuff to tests directory
Chad Horohoe [Tue, 28 Sep 2010 12:24:56 +0000 (12:24 +0000)]
Move parser test related stuff to tests directory
* Moved test record stuff to testHelpers.inc, could be useful for non-parser test stuff?
* Everything else in tests/parser
* parserTestsParserTime from r12533 doesn't seem used?

13 years agoSanity check on result from SHOW PROCESSLIST, foreach -> while (sorta followup to...
Chad Horohoe [Tue, 28 Sep 2010 11:39:10 +0000 (11:39 +0000)]
Sanity check on result from SHOW PROCESSLIST, foreach -> while (sorta followup to r68878)

13 years agoMore bug 671: whitelist <kbd> and <samp> for user input. Followup per r70164's comment.
Chad Horohoe [Tue, 28 Sep 2010 11:12:56 +0000 (11:12 +0000)]
More bug 671: whitelist <kbd> and <samp> for user input. Followup per r70164's comment.

13 years agoReplace imho ugly viewsourcefor subtitle with viewsourcetitle and viewsourceheader...
Niklas Laxström [Tue, 28 Sep 2010 10:04:22 +0000 (10:04 +0000)]
Replace imho ugly viewsourcefor subtitle with viewsourcetitle and viewsourceheader (for <title> and <h1> respectively).

13 years agoFollow-up r68878: ensure that returned value is int
Max Semenik [Tue, 28 Sep 2010 08:32:09 +0000 (08:32 +0000)]
Follow-up r68878: ensure that returned value is int

13 years agoDon't show empty source code for non-existing pages if editing was prevented by a...
Niklas Laxström [Tue, 28 Sep 2010 08:16:42 +0000 (08:16 +0000)]
Don't show empty source code for non-existing pages if editing was prevented by a permission error

13 years agoFix icky info/error/warning box styling
Chad Horohoe [Tue, 28 Sep 2010 03:18:49 +0000 (03:18 +0000)]
Fix icky info/error/warning box styling

13 years agoClean tabs/spaces for r73853
Brion Vibber [Tue, 28 Sep 2010 02:33:43 +0000 (02:33 +0000)]
Clean tabs/spaces for r73853

13 years agoFix tab/space, use null as default value rather than string to match expected return...
Brion Vibber [Tue, 28 Sep 2010 02:24:59 +0000 (02:24 +0000)]
Fix tab/space, use null as default value rather than string to match expected return (cleanup from r73859)

13 years agoTweak tab vs spaces from r73860
Brion Vibber [Tue, 28 Sep 2010 02:18:35 +0000 (02:18 +0000)]
Tweak tab vs spaces from r73860

13 years agoTweak/add some documentation as hints for some code analysis
Sam Reed [Tue, 28 Sep 2010 01:33:11 +0000 (01:33 +0000)]
Tweak/add some documentation as hints for some code analysis

13 years agoDefine variable before usage in hook call
Sam Reed [Tue, 28 Sep 2010 01:21:38 +0000 (01:21 +0000)]
Define variable before usage in hook call

13 years agoSwap a couple of while loops for foreach
Sam Reed [Tue, 28 Sep 2010 01:21:15 +0000 (01:21 +0000)]
Swap a couple of while loops for foreach

13 years agoMinor followup to r66061, make the examples more explicit/verbose (different types...
Sam Reed [Tue, 28 Sep 2010 00:56:04 +0000 (00:56 +0000)]
Minor followup to r66061, make the examples more explicit/verbose (different types of query module)

13 years agoImproves on fix in r73808 which was aimed at correcting a mistake made when making...
Trevor Parscal [Mon, 27 Sep 2010 23:50:20 +0000 (23:50 +0000)]
Improves on fix in r73808 which was aimed at correcting a mistake made when making IEFixes.js ResourceLoader compatible. This uses the undefined keyword as an initial value, to emulate the value that would be assigned when using "var myVariable;".

13 years agoAdds a make target to build phpunit code coverage which will be generated to
Antoine Musso [Mon, 27 Sep 2010 20:19:22 +0000 (20:19 +0000)]
Adds a make target to build phpunit code coverage which will be generated to
/docs/code-coverage . You will need the Xdebug PHP extension to run code
coverage.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Mon, 27 Sep 2010 19:39:45 +0000 (19:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-27 19:19:00 UTC)

13 years agoupdate my personal email address (following r73779)
Antoine Musso [Mon, 27 Sep 2010 18:46:16 +0000 (18:46 +0000)]
update my personal email address (following r73779)

13 years agoFixed typo in a comment
Trevor Parscal [Mon, 27 Sep 2010 18:43:21 +0000 (18:43 +0000)]
Fixed typo in a comment

13 years ago* Improved on r73567, this makes WebRequest::getFuzzyBool case insensitive, making...
Trevor Parscal [Mon, 27 Sep 2010 15:59:58 +0000 (15:59 +0000)]
* Improved on r73567, this makes WebRequest::getFuzzyBool case insensitive, making 'false', 'FALSE', 'FaLsE', etc to be boolean false
* Fixed syntax error in Skin.php

13 years agoRevert r72816 and do it properly: the SELECT should be executed on the master
Roan Kattouw [Mon, 27 Sep 2010 15:51:47 +0000 (15:51 +0000)]
Revert r72816 and do it properly: the SELECT should be executed on the master

13 years agoFix a bunch of '? true : false' instances
Chad Horohoe [Mon, 27 Sep 2010 14:24:13 +0000 (14:24 +0000)]
Fix a bunch of '? true : false' instances

13 years agoFix an instance of window.someVar; that slipped through the cracks
Roan Kattouw [Mon, 27 Sep 2010 13:06:58 +0000 (13:06 +0000)]
Fix an instance of window.someVar; that slipped through the cracks

13 years agoFix indentation
Roan Kattouw [Mon, 27 Sep 2010 13:06:35 +0000 (13:06 +0000)]
Fix indentation

13 years agoFix indentation
Roan Kattouw [Mon, 27 Sep 2010 12:30:04 +0000 (12:30 +0000)]
Fix indentation

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sun, 26 Sep 2010 19:56:28 +0000 (19:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-26 19:39:00 UTC)

13 years ago* (bug 25292) SkinSubPageSubtitle hook now passes the Skin object as second parameter
Alexandre Emsenhuber [Sun, 26 Sep 2010 16:37:00 +0000 (16:37 +0000)]
* (bug 25292) SkinSubPageSubtitle hook now passes the Skin object as second parameter

13 years agoupdate my personal email address altern.org -> free.fr
Antoine Musso [Sun, 26 Sep 2010 15:52:51 +0000 (15:52 +0000)]
update my personal email address altern.org -> free.fr

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sat, 25 Sep 2010 19:37:18 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-25 19:25:00 UTC)

13 years agoA few index-related fixes in SQLite DB patches, ping r66920.
Max Semenik [Sat, 25 Sep 2010 17:45:00 +0000 (17:45 +0000)]
A few index-related fixes in SQLite DB patches, ping r66920.

The need to drop index patch-rename-iwl_prefix.sql arose from development versions that had discrepancies between tables.sql and updater. Let's just DROP IF EXISTS it.

13 years agoAdd missing @'s to r73753, document return type
Sam Reed [Sat, 25 Sep 2010 17:17:27 +0000 (17:17 +0000)]
Add missing @'s to r73753, document return type

13 years ago$name used in continue is undefined, use $message
Sam Reed [Sat, 25 Sep 2010 17:08:23 +0000 (17:08 +0000)]
$name used in continue is undefined, use $message

Though, this module seems to have no limits, so not sure why we have a continue/"from"

13 years agoextract is weird
Sam Reed [Sat, 25 Sep 2010 17:01:17 +0000 (17:01 +0000)]
extract is weird

Do what extract is doing explicitally

13 years agoRevert r73587 and fix r62087 regression by providing the default value in $comment...
Platonides [Sat, 25 Sep 2010 16:58:32 +0000 (16:58 +0000)]
Revert r73587 and fix r62087 regression by providing the default value in $comment definition.
This not only fixes the issue of line 189, but also the one at line 156.

13 years agoRemove some unused keys from foreach
Sam Reed [Sat, 25 Sep 2010 16:56:03 +0000 (16:56 +0000)]
Remove some unused keys from foreach

Documentation tweaks

13 years agoFill in missing params from a dieUsage
Sam Reed [Sat, 25 Sep 2010 16:45:41 +0000 (16:45 +0000)]
Fill in missing params from a dieUsage

Braces

Fixup parameter documentation

13 years agoWhat's a boolif?
Sam Reed [Sat, 25 Sep 2010 16:38:44 +0000 (16:38 +0000)]
What's a boolif?

13 years agoRemove some unused variables
Sam Reed [Sat, 25 Sep 2010 16:37:39 +0000 (16:37 +0000)]
Remove some unused variables

Tweak php doc, "One" is not a type, so insert string in there

13 years agoadds testing for IP and Xml classes
Antoine Musso [Sat, 25 Sep 2010 16:09:16 +0000 (16:09 +0000)]
adds testing for IP and Xml classes

13 years agocomment typo
Antoine Musso [Sat, 25 Sep 2010 16:08:24 +0000 (16:08 +0000)]
comment typo

13 years ago* Fixed bug #25281 by adding special treatment for modules in the "private" group
Trevor Parscal [Fri, 24 Sep 2010 22:10:25 +0000 (22:10 +0000)]
* Fixed bug #25281 by adding special treatment for modules in the "private" group
* Added $wgResourceLoaderInlinePrivateModules to allow private modules to be either embedded in the HTML output or accessed through ResourceLoader (which will bypass squid cache and check the user paramter against $wgUser)
* Moved more generated javascript functionality to ResourceLoader
* Fixed comment typo made in r73673
* Added documentation for ResoruceLoaderRegisterModules hook

13 years agoMoved more generated javascript to ResourceLoader functions. Cleaned some things...
Trevor Parscal [Fri, 24 Sep 2010 21:03:29 +0000 (21:03 +0000)]
Moved more generated javascript to ResourceLoader functions. Cleaned some things up in the startup module.

13 years agoSupport ESI in the resource loader. Only used for the startup module for now, we...
Roan Kattouw [Fri, 24 Sep 2010 20:01:52 +0000 (20:01 +0000)]
Support ESI in the resource loader. Only used for the startup module for now, we'll have to think our ESI strategy through before expanding on that

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Fri, 24 Sep 2010 19:22:35 +0000 (19:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-24 19:02:00 UTC)

13 years ago* Moved registration generation to startup module.
Trevor Parscal [Fri, 24 Sep 2010 18:49:19 +0000 (18:49 +0000)]
* Moved registration generation to startup module.
* Moved some javascript code generation to reusable functions (more to do).
* Reduced the code output by using mutliple calling method for mediaWiki.loader.state.
* Moved CSS minification to the end (should be a bit faster than running it for each module).

13 years agoFix r73645: also do negative caching
Roan Kattouw [Fri, 24 Sep 2010 18:16:59 +0000 (18:16 +0000)]
Fix r73645: also do negative caching

13 years agoAdded early exits when files are used before webstart
Trevor Parscal [Fri, 24 Sep 2010 17:31:40 +0000 (17:31 +0000)]
Added early exits when files are used before webstart

13 years agoFixed issue in r73645 where an unset value was being returned in some cases.
Trevor Parscal [Fri, 24 Sep 2010 17:19:27 +0000 (17:19 +0000)]
Fixed issue in r73645 where an unset value was being returned in some cases.

13 years agoreimplement r73652 having actually read coding conventions this time
Matthew Britton [Fri, 24 Sep 2010 14:40:18 +0000 (14:40 +0000)]
reimplement r73652 having actually read coding conventions this time

13 years agoAPI: sinumberingroup now gives correct size of 'user' group, and omits size of implic...
Matthew Britton [Fri, 24 Sep 2010 13:00:46 +0000 (13:00 +0000)]
API: sinumberingroup now gives correct size of 'user' group, and omits size of implicit groups rather than showing 0.

13 years agoImproved the performance of ResourceLoader by pre-loading module information in a...
Trevor Parscal [Thu, 23 Sep 2010 21:23:51 +0000 (21:23 +0000)]
Improved the performance of ResourceLoader by pre-loading module information in a batch query. This was mostly code written by catrope and patched in / gotten working by me.

13 years agoFollow-up r73632: Fix typo
Raimond Spekking [Thu, 23 Sep 2010 19:45:46 +0000 (19:45 +0000)]
Follow-up r73632: Fix typo

13 years agoFixed some doxygen warnings
Alexandre Emsenhuber [Thu, 23 Sep 2010 19:41:29 +0000 (19:41 +0000)]
Fixed some doxygen warnings

13 years agoFixed a glitch from r73632
Max Semenik [Thu, 23 Sep 2010 19:39:32 +0000 (19:39 +0000)]
Fixed a glitch from r73632

13 years agoSpecial:Version now displays whether a SQLite database supports full-text search
Max Semenik [Thu, 23 Sep 2010 19:36:06 +0000 (19:36 +0000)]
Special:Version now displays whether a SQLite database supports full-text search

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Thu, 23 Sep 2010 19:30:38 +0000 (19:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-23 19:15:00 UTC)

13 years ago(bug 25273) Message::params() triggers a fatal error.
Niklas Laxström [Thu, 23 Sep 2010 19:15:58 +0000 (19:15 +0000)]
(bug 25273) Message::params() triggers a fatal error.

Patch by hashar.

13 years agoFixed typo pointed out by Icefox - thanks! See comments for r73499.
Trevor Parscal [Thu, 23 Sep 2010 18:08:20 +0000 (18:08 +0000)]
Fixed typo pointed out by Icefox - thanks! See comments for r73499.

13 years agofollow up r72387: using ApiQuery here breaks ApiParamInfo (bug 25248)
Matthew Britton [Thu, 23 Sep 2010 10:46:08 +0000 (10:46 +0000)]
follow up r72387: using ApiQuery here breaks ApiParamInfo (bug 25248)

13 years agoReplace $ with $j in ajaxwatch.js, was causing fatal JS errors on pages for me. ...
Andrew Garrett [Thu, 23 Sep 2010 06:18:46 +0000 (06:18 +0000)]
Replace $ with $j in ajaxwatch.js, was causing fatal JS errors on pages for me. (resourceloader-related issue?)

13 years agoFix regression caused by r62087 which failed to insert rows into the image table...
OverlordQ [Thu, 23 Sep 2010 02:59:07 +0000 (02:59 +0000)]
Fix regression caused by r62087 which failed to insert rows into the image table due to null comment.
Also correct indefinite/infinite/infinity protection.

13 years ago* Optimized watch star sprite (only linking to the the image once rather than 4 times...
Trevor Parscal [Wed, 22 Sep 2010 21:49:31 +0000 (21:49 +0000)]
* Optimized watch star sprite (only linking to the the image once rather than 4 times, makes data-URLs more efficient)
* Removed version numbers from links

13 years agoFollowup to r73500. SeleniumTestConfig renamed to SeleniumConfig. Make sure SELENIUMT...
Priyanka Dhanda [Wed, 22 Sep 2010 21:23:21 +0000 (21:23 +0000)]
Followup to r73500. SeleniumTestConfig renamed to SeleniumConfig. Make sure SELENIUMTEST is defined to use it.
Fixed some indents and pass by reference warnings

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Wed, 22 Sep 2010 21:05:23 +0000 (21:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-22 20:51:00 UTC)

13 years ago* Added $wgResourceLoaderDebug, a default fallback for debug mode which can be overri...
Trevor Parscal [Wed, 22 Sep 2010 20:44:12 +0000 (20:44 +0000)]
* Added $wgResourceLoaderDebug, a default fallback for debug mode which can be overridden by the debug URL parameter a la $wgLanguageCode
* Merged $wgResourceLoader(Unv|V)ersioned(Client|Server)Maxage vars into $wgResourceLoaderMaxage, which contains an array of the same values.

13 years ago* Added WebRequest::getFuzzyBool, which is a more JavaScript friendly version of...
Trevor Parscal [Wed, 22 Sep 2010 20:15:31 +0000 (20:15 +0000)]
* Added WebRequest::getFuzzyBool, which is a more JavaScript friendly version of getBool. Essentailly the same thing, except the string 'false' is also considered boolean false.
* Made use of getFuzzyBool where otherwise awkward and sometimes varied versions of 'flase' === false detection were being used.

13 years agoActually improves on fix for bug #25246 by reducing the power of the foreground color...
Trevor Parscal [Wed, 22 Sep 2010 20:11:30 +0000 (20:11 +0000)]
Actually improves on fix for bug #25246 by reducing the power of the foreground color rule - it was overriding the placeholder class. This corrects a mistake made in r73562.

13 years agoSkip new object construction if it's going to be the same
Chad Horohoe [Wed, 22 Sep 2010 19:19:47 +0000 (19:19 +0000)]
Skip new object construction if it's going to be the same

13 years agoImproves on fix for bug #25246 by reducing the power of the foreground color rule...
Trevor Parscal [Wed, 22 Sep 2010 19:15:53 +0000 (19:15 +0000)]
Improves on fix for bug #25246 by reducing the power of the foreground color rule - it was overriding the placeholder class.

13 years agoFix dupe title construction, reported by ymas on IRC
Chad Horohoe [Wed, 22 Sep 2010 19:09:14 +0000 (19:09 +0000)]
Fix dupe title construction, reported by ymas on IRC

13 years agoResolves bug #25246 by adding an explicit foreground color to the search box.
Trevor Parscal [Wed, 22 Sep 2010 18:36:57 +0000 (18:36 +0000)]
Resolves bug #25246 by adding an explicit foreground color to the search box.