From: Tim Starling <tstarling@users.mediawiki.org>
Date: Thu, 22 Sep 2011 03:37:39 +0000 (+0000)
Subject: Removed the redundant wfMkdirParents() call added to BitmapHandler::doTransform(... 
X-Git-Tag: 1.31.0-rc.0~27489
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=b9fcd0c14a2ae49dc4be8180239c5e0257cff7eb;p=lhc%2Fweb%2Fwiklou.git

Removed the redundant wfMkdirParents() call added to BitmapHandler::doTransform() in r79845. This causes problems on Wikimedia due to incorrect NFS access. If a sysadmin misconfigures their thumbnail destination directory, they should get a helpful error message, it shouldn't transparently fall back to client-side scaling and cache the resulting HTML forever.
---

diff --git a/includes/media/Bitmap.php b/includes/media/Bitmap.php
index 24f0dbd0c5..00d6dc28af 100644
--- a/includes/media/Bitmap.php
+++ b/includes/media/Bitmap.php
@@ -223,13 +223,6 @@ class BitmapHandler extends ImageHandler {
 		} else {
 			$scaler = 'client';
 		}
-
-		if ( $scaler != 'client' && $dstPath ) {
-			if ( !wfMkdirParents( dirname( $dstPath ), null, __METHOD__ ) ) {
-				# Unable to create a path for the thumbnail
-				return 'client';
-			}
-		}
 		return $scaler;
 	}