From: Platonides <platonides@users.mediawiki.org>
Date: Thu, 10 Feb 2011 16:54:51 +0000 (+0000)
Subject: Move the overhead computation to another function.
X-Git-Tag: 1.31.0-rc.0~32064
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=b51b77bba13a57f31568fee9803a077af42e328a;p=lhc%2Fweb%2Fwiklou.git

Move the overhead computation to another function.
---

diff --git a/includes/Profiler.php b/includes/Profiler.php
index 6deb742e26..551ce233ce 100644
--- a/includes/Profiler.php
+++ b/includes/Profiler.php
@@ -263,12 +263,7 @@ class Profiler {
 
 		# Estimate profiling overhead
 		$profileCount = count($this->mStack);
-		wfProfileIn( '-overhead-total' );
-		for( $i = 0; $i < $profileCount; $i ++ ){
-			wfProfileIn( '-overhead-internal' );
-			wfProfileOut( '-overhead-internal' );
-		}
-		wfProfileOut( '-overhead-total' );
+		self::calculateOverhead( $profileCount );
 
 		# First, subtract the overhead!
 		$overheadTotal = $overheadMemory = $overheadInternal = array();
@@ -347,6 +342,18 @@ class Profiler {
 		return $prof;
 	}
 
+	/**
+	 * Dummy calls to wfProfileIn/wfProfileOut to calculate its overhead
+	 */
+	protected static function calculateOverhead( $profileCount ) {
+		wfProfileIn( '-overhead-total' );
+		for( $i = 0; $i < $profileCount; $i++ ){
+			wfProfileIn( '-overhead-internal' );
+			wfProfileOut( '-overhead-internal' );
+		}
+		wfProfileOut( '-overhead-total' );
+	}
+	
 	/**
 	 * Counts the number of profiled function calls sitting under
 	 * the given point in the call graph. Not the most efficient algo.