From: Mattflaschen <mflaschen@wikimedia.org>
Date: Mon, 20 Oct 2014 18:01:21 +0000 (+0000)
Subject: Revert "Add maxlength of 6 for time correction in preferences"
X-Git-Tag: 1.31.0-rc.0~13559^2
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=b07b5af4854426518aca81a490aae8454ac74b02;p=lhc%2Fweb%2Fwiklou.git

Revert "Add maxlength of 6 for time correction in preferences"

As noted by Bartosz, System|60 is also valid (apparently also
ZoneInfo|something, but not sure what can go after ZoneInfo), and the
maxlength interferes with this.

Maybe eventually we could revisit and use input#pattern
(http://www.w3.org/TR/html51/forms.html#the-pattern-attribute).  That
allows specifying a regex, which could have different length limits
depending whether it started with a number (AFAICT, the 6 length is valid
if it starts with a digit).

But for now, that is not urgent, and we need to fix the regression.

This reverts commit da470ce005652774049d346142b9509e89b31c6b.

Bug: 70405
Change-Id: Ib585c76688284dab78e85fb355785c06d0c3e353
---

diff --git a/includes/Preferences.php b/includes/Preferences.php
index 98fc936df4..84cf5af0f0 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -706,7 +706,6 @@ class Preferences {
 			'options' => $tzOptions,
 			'default' => $tzSetting,
 			'size' => 20,
-			'maxlength' => 6,
 			'section' => 'rendering/timeoffset',
 		);
 	}