From: Bryan Tong Minh <btongminh@users.mediawiki.org>
Date: Sun, 11 Apr 2010 13:54:22 +0000 (+0000)
Subject: Follow up r64932: Add comment on why % is escaped
X-Git-Tag: 1.31.0-rc.0~37144
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=879abd9113851227053f73c5195d226d91fc41ba;p=lhc%2Fweb%2Fwiklou.git

Follow up r64932: Add comment on why % is escaped
---

diff --git a/includes/media/Bitmap.php b/includes/media/Bitmap.php
index 9b082b2a33..f9116442fb 100644
--- a/includes/media/Bitmap.php
+++ b/includes/media/Bitmap.php
@@ -157,6 +157,7 @@ class BitmapHandler extends ImageHandler {
 				// or ImageMagick may decide your ratio is wrong and slice off
 				// a pixel.
 				" -thumbnail " . wfEscapeShellArg( "{$physicalWidth}x{$physicalHeight}!" ) .
+				// A % is an escape character in ImageMagick
 				" -set comment " . wfEscapeShellArg( str_replace( '%', '%%', $descriptionUrl ) ) .
 				" -depth 8 $sharpen " .
 				wfEscapeShellArg($dstPath) . " 2>&1";