From: Tim Starling <tstarling@users.mediawiki.org>
Date: Tue, 21 Dec 2010 02:57:33 +0000 (+0000)
Subject: Actually skip invalid titles in XML dumps, don't just say you're going to. Avoids... 
X-Git-Tag: 1.31.0-rc.0~33223
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=5e8d27cc162aca290c1112c38e295d0651f93f9e;p=lhc%2Fweb%2Fwiklou.git

Actually skip invalid titles in XML dumps, don't just say you're going to. Avoids fatal error.
---

diff --git a/includes/ImportXMLReader.php b/includes/ImportXMLReader.php
index 790d1a0d83..e221eaca06 100644
--- a/includes/ImportXMLReader.php
+++ b/includes/ImportXMLReader.php
@@ -619,9 +619,10 @@ class WikiImporter {
 		if( is_null( $title ) ) {
 			// Invalid page title? Ignore the page
 			$this->notice( "Skipping invalid page title '$workTitle'" );
+			return false;
 		} elseif( $title->getInterwiki() != '' ) {
 			$this->notice( "Skipping interwiki page title '$workTitle'" );
-			$title = null;
+			return false;
 		}
 
 		return array( $origTitle, $title );