From: This, that and the other <at.light@live.com.au>
Date: Mon, 21 Jul 2014 07:38:39 +0000 (+1000)
Subject: Preferences: Turn stubthreshold back into a combo box
X-Git-Tag: 1.31.0-rc.0~14821^2
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=588880c5f0567fca144a37066e87db3712ef32ac;p=lhc%2Fweb%2Fwiklou.git

Preferences: Turn stubthreshold back into a combo box

Currently it's an insanely tall list box. All the other settings on this
page use combo boxes, so we should be consistent.

After it was changed from 'selectorother' to 'select' in I88212703
and support for 'size' in HTMLSelectField was enabled in I7ac345e1,
the size defines the height of the select box instead of the width of
the text input field.

Bug: 68313
Change-Id: Id42a62e78fc2fee741bb02b88dc14cbb1b63635a
---

diff --git a/includes/Preferences.php b/includes/Preferences.php
index 482c24b64b..b4bb6de638 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -750,7 +750,6 @@ class Preferences {
 			'type' => 'select',
 			'section' => 'rendering/advancedrendering',
 			'options' => $stubThresholdOptions,
-			'size' => 20,
 			'label-raw' => $context->msg( 'stub-threshold' )->text(), // Raw HTML message. Yay?
 		);