From: Roan Kattouw Date: Mon, 9 Feb 2009 15:15:49 +0000 (+0000) Subject: Remove a TODO from ApiMove and add a FIXME to SpecialMovepage X-Git-Tag: 1.31.0-rc.0~42964 X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=40b6193c066fbdfb7979b7f3520eb402be7da53c;p=lhc%2Fweb%2Fwiklou.git Remove a TODO from ApiMove and add a FIXME to SpecialMovepage --- diff --git a/includes/api/ApiMove.php b/includes/api/ApiMove.php index 1045f3e57d..c3a5e7dbec 100644 --- a/includes/api/ApiMove.php +++ b/includes/api/ApiMove.php @@ -107,7 +107,6 @@ class ApiMove extends ApiBase { $r['subpages'] = $this->moveSubpages($fromTitle, $toTitle, $params['reason'], $params['noredirect']); $this->getResult()->setIndexedTagName($r['subpages'], 'subpage'); - // TODO: Should we move talk subpages if moving the talk page failed? if($params['movetalk']) { $r['subpages-talk'] = $this->moveSubpages($fromTalk, $toTalk, diff --git a/includes/specials/SpecialMovepage.php b/includes/specials/SpecialMovepage.php index 7e6f101eb8..7acfd259e7 100644 --- a/includes/specials/SpecialMovepage.php +++ b/includes/specials/SpecialMovepage.php @@ -378,6 +378,8 @@ class MovePageForm { # would mean that you couldn't move them back in one operation, which # is bad. FIXME: A specific error message should be given in this # case. + + // FIXME: Use Title::moveSubpages() here $dbr = wfGetDB( DB_MASTER ); if( $this->moveSubpages && ( MWNamespace::hasSubpages( $nt->getNamespace() ) || (