From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 9 Aug 2016 23:45:37 +0000 (-0700)
Subject: Clean up some IDatabase comments
X-Git-Tag: 1.31.0-rc.0~6113^2
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=3155b5850f98009cb6876282e1604a2780d6ab9c;p=lhc%2Fweb%2Fwiklou.git

Clean up some IDatabase comments

Change-Id: Ia4b344a412e78185b6b2fe584540a358c35651b8
---

diff --git a/includes/db/DatabaseMysqlBase.php b/includes/db/DatabaseMysqlBase.php
index ee84224eaa..798815d4d1 100644
--- a/includes/db/DatabaseMysqlBase.php
+++ b/includes/db/DatabaseMysqlBase.php
@@ -1186,12 +1186,6 @@ abstract class DatabaseMysqlBase extends Database {
 		return $this->lastErrno() == 1205;
 	}
 
-	/**
-	 * Determines if the last query error was something that should be dealt
-	 * with by pinging the connection and reissuing the query
-	 *
-	 * @return bool
-	 */
 	function wasErrorReissuable() {
 		return $this->lastErrno() == 2013 || $this->lastErrno() == 2006;
 	}
diff --git a/includes/db/IDatabase.php b/includes/db/IDatabase.php
index 9dcbd7f278..43592e2743 100644
--- a/includes/db/IDatabase.php
+++ b/includes/db/IDatabase.php
@@ -1156,7 +1156,6 @@ interface IDatabase {
 
 	/**
 	 * Determines how long the server has been up
-	 * STUB
 	 *
 	 * @return int
 	 */
@@ -1164,7 +1163,6 @@ interface IDatabase {
 
 	/**
 	 * Determines if the last failure was due to a deadlock
-	 * STUB
 	 *
 	 * @return bool
 	 */
@@ -1172,16 +1170,14 @@ interface IDatabase {
 
 	/**
 	 * Determines if the last failure was due to a lock timeout
-	 * STUB
 	 *
 	 * @return bool
 	 */
 	public function wasLockTimeout();
 
 	/**
-	 * Determines if the last query error was something that should be dealt
-	 * with by pinging the connection and reissuing the query.
-	 * STUB
+	 * Determines if the last query error was due to a dropped connection and should
+	 * be dealt with by pinging the connection and reissuing the query.
 	 *
 	 * @return bool
 	 */
@@ -1189,7 +1185,6 @@ interface IDatabase {
 
 	/**
 	 * Determines if the last failure was due to the database being read-only.
-	 * STUB
 	 *
 	 * @return bool
 	 */