From: Roan Kattouw <catrope@users.mediawiki.org>
Date: Sat, 16 Aug 2008 21:00:19 +0000 (+0000)
Subject: API: Let list=search throw away missing titles. Lucene will sometimes give us pages... 
X-Git-Tag: 1.31.0-rc.0~45866
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=2059e76f81e10aa64ef0847b69b37e34d9d7afa5;p=lhc%2Fweb%2Fwiklou.git

API: Let list=search throw away missing titles. Lucene will sometimes give us pages that have recently been deleted.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 17098645d9..2248751efe 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -148,6 +148,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 15048) Added limit field for multivalue parameters to action=paraminfo
   output.
 * When the limit on multivalue parameters is exceeded, a warning is issued
+* list=search doesn't list missing pages any more
 
 === Languages updated in 1.14 ===
 
diff --git a/includes/api/ApiQuerySearch.php b/includes/api/ApiQuerySearch.php
index 932ca5055d..85d4ec8e63 100644
--- a/includes/api/ApiQuerySearch.php
+++ b/includes/api/ApiQuerySearch.php
@@ -93,8 +93,9 @@ class ApiQuerySearch extends ApiQueryGeneratorBase {
 				break;
 			}
 
-			// Silently skip broken titles
-			if ($result->isBrokenTitle()) continue;
+			// Silently skip broken and missing titles
+			if ($result->isBrokenTitle() || $result->isMissingRevision())
+				continue;
 			
 			$title = $result->getTitle();
 			if (is_null($resultPageSet)) {