From: Moriel Schottlender <moriel@gmail.com>
Date: Tue, 18 Apr 2017 00:06:47 +0000 (-0700)
Subject: RCFilters UI: Display 'no results found' if... no results were found!
X-Git-Tag: 1.31.0-rc.0~3487^2
X-Git-Url: https://git.cyclocoop.org/%242?a=commitdiff_plain;h=03f33cea41b566cbb4b2b98c4e4e240d24bbd1ad;p=lhc%2Fweb%2Fwiklou.git

RCFilters UI: Display 'no results found' if... no results were found!

The "normal" operation of an OO.ui.MenuSelectWidget is to hide itself
if no results are found in the filtering process. However, we want
the menu to remain visible but display a 'no filters found' message
like it did before the migration to a MenuTagMultiselectWidget.

Bug: T163170
Change-Id: Iee7b07961b90ac514a4aa1f7c56019ecd7b4c3cc
---

diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.less
index 194b1b21d0..7602465e31 100644
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.less
@@ -4,6 +4,20 @@
 	z-index: auto;
 	max-width: 650px;
 
+	&.oo-ui-menuSelectWidget-invisible {
+		display: block;
+	}
+
+	&-noresults {
+		display: none;
+		padding: 0.5em;
+		color: #666;
+
+		.oo-ui-menuSelectWidget-invisible & {
+			display: inline-block;
+		}
+	}
+
 	&-body {
 		max-height: 70vh;
 	}
diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.js
index ec85df98da..748eea8a8e 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterFloatingMenuSelectWidget.js
@@ -45,11 +45,16 @@
 			}
 		);
 
+		this.noResults = new OO.ui.LabelWidget( {
+			label: mw.msg( 'rcfilters-filterlist-noresults' ),
+			classes: [ 'mw-rcfilters-ui-filterFloatingMenuSelectWidget-noresults' ]
+		} );
+
 		this.$element
 			.addClass( 'mw-rcfilters-ui-filterFloatingMenuSelectWidget' )
 			.append(
 				this.$body
-					.append( header.$element, this.$group )
+					.append( header.$element, this.$group, this.noResults.$element )
 			);
 
 		if ( this.$footer ) {