Bug 39495 - action=info contains hard coded English text "Marked as

'$1'"

* Added messages for two valid values of robot indexing policy

Change-Id: If1dc1de6b2607fcaf546ffce74e039e5f9d170fa

diff --git a/includes/actions/InfoAction.php b/includes/actions/InfoAction.php
index 60941c8..26a6e47 100644 (file)
--- a/includes/actions/InfoAction.php
+++ b/includes/actions/InfoAction.php
@@ -121,9 +121,9 @@ class InfoAction extends FormlessAction {
 
                // Use robot policy logic
                $policy = $this->page->getRobotPolicy( 'view', $pOutput );
-               // @todo FIXME: Hard coded English text.
                $table = $this->addRow( $table,
-                       $this->msg( 'pageinfo-robot-policy' )->escaped(), "Marked as '" . $policy['index'] . "'"
+                       $this->msg( 'pageinfo-robot-policy' )->escaped(),
+                       $this->msg( "pageinfo-robot-${policy['index']}" )->escaped()
                );
 
                if ( !$wgDisableCounters ) {

diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index 9fba52f..e290a4c 100644 (file)
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -3742,6 +3742,8 @@ This is probably caused by a link to a blacklisted external site.',
 'pageinfo-length'              => 'Page length (in bytes)',
 'pageinfo-article-id'          => 'Page ID',
 'pageinfo-robot-policy'        => 'Search engine status',
+'pageinfo-robot-index'         => 'Indexable',
+'pageinfo-robot-noindex'       => 'Not indexable',
 'pageinfo-views'               => 'Number of views',
 'pageinfo-watchers'            => 'Number of page watchers',
 'pageinfo-redirects-name'      => 'Redirects to this page',

diff --git a/languages/messages/MessagesQqq.php b/languages/messages/MessagesQqq.php
index 1e15897..4e31fce 100644 (file)
--- a/languages/messages/MessagesQqq.php
+++ b/languages/messages/MessagesQqq.php
@@ -3462,6 +3462,8 @@ See also {{msg-mw|Anonuser}} and {{msg-mw|Siteusers}}.',
 'pageinfo-length' => 'The length of the page, in bytes.',
 'pageinfo-article-id' => 'The numeric identifier of the page.',
 'pageinfo-robot-policy' => 'The search engine status of the page.',
+'pageinfo-robot-index' => 'An indication that the page is indexable.',
+'pageinfo-robot-noindex' => 'An indication that the page is not indexable.',
 'pageinfo-views' => 'The number of times the page has been viewed.',
 'pageinfo-watchers' => 'The number of users watching the page.',
 'pageinfo-redirects-name' => 'The number of redirects to the page.',

diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc
index 79c6ec7..f6be347 100644 (file)
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -2672,6 +2672,8 @@ $wgMessageStructure = array(
                'pageinfo-length',
                'pageinfo-article-id',
                'pageinfo-robot-policy',
+               'pageinfo-robot-index',
+               'pageinfo-robot-noindex',
                'pageinfo-views',
                'pageinfo-watchers',
                'pageinfo-redirects-name',