Remove "wtf" $_GET hacks ;)

diff --git a/includes/LogEventsList.php b/includes/LogEventsList.php
index e8b7b2e..69e54da 100644 (file)
--- a/includes/LogEventsList.php
+++ b/includes/LogEventsList.php
@@ -386,8 +386,12 @@ class LogPager extends ReverseChronologicalPager {
                $this->limitType( $type );
                $this->limitUser( $user );
                $this->limitTitle( $title, $pattern );
-               # Hack to recognize subpage parameter
-               $_GET['type'] = $type;
+       }
+       
+       function getDefaultQuery() {
+               $query = parent::getDefaultQuery();
+               $query['type'] = $this->type;
+               return $query;
        }
        
        /**

diff --git a/includes/SpecialContributions.php b/includes/SpecialContributions.php
index 63e14c5..44df343 100644 (file)
--- a/includes/SpecialContributions.php
+++ b/includes/SpecialContributions.php
@@ -30,6 +30,8 @@ class ContribsPager extends ReverseChronologicalPager {
        function getDefaultQuery() {
                $query = parent::getDefaultQuery();
                $query['target'] = $this->target;
+               $query['month'] = $this->month;
+               $query['year'] = $this->year;
                return $query;
        }
 
@@ -279,9 +281,7 @@ function wfSpecialContributions( $par = null ) {
        wfRunHooks( 'SpecialContributionsBeforeMainOutput', $id );
 
        $wgOut->addHTML( contributionsForm( $options ) );
-       # Show original selected options, don't apply them so as to allow paging
-       $_GET['year'] = ''; // hack for Pager
-       $_GET['month'] = ''; // hack for Pager
+       
        if( $skip ) {
                $options['year'] = '';
                $options['month'] = '';