add Revision::selectFields(): returns a list of fields that should be SELECTed to...

diff --git a/includes/Revision.php b/includes/Revision.php
index 0758d3f..357a856 100644 (file)
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -248,6 +248,25 @@ class Revision {
                return $ret;
        }
 
+       /**
+        * Return the list of revision fields that should be selected to create 
+        * a new revision.
+        */
+       static function selectFields() {
+               return array( 
+                       'rev_id',
+                       'rev_page',
+                       'rev_text_id',
+                       'rev_timestamp',
+                       'rev_comment',
+                       'rev_minor_edit',
+                       'rev_user',
+                       'rev_user_text,'.
+                       'rev_deleted',
+                       'rev_len'
+               );
+       }
+
        /**
         * @param object $row
         * @access private

diff --git a/includes/SpecialContributions.php b/includes/SpecialContributions.php
index e4430b4..f1da5d5 100644 (file)
--- a/includes/SpecialContributions.php
+++ b/includes/SpecialContributions.php
@@ -163,9 +163,8 @@ class ContribsFinder {
                $use_index = $this->dbr->useIndexClause( $index );
                $sql = 'SELECT ' .
                        'page_namespace,page_title,page_is_new,page_latest,'.
-                       'rev_id,rev_page,rev_text_id,rev_timestamp,rev_comment,rev_minor_edit,rev_user,rev_user_text,'.
-                       'rev_deleted,rev_len ' .
-                       "FROM $page,$revision $use_index " .
+                       join(',', Revision::selectFields()).
+                       " FROM $page,$revision $use_index " .
                        "WHERE page_id=rev_page AND $userCond $nscond $offsetQuery " .
                        'ORDER BY rev_timestamp DESC';
                $sql = $this->dbr->limitResult( $sql, $this->limit, 0 );