Stop doing $that = $this in includes/specials

Closures support $this as of PHP 5.4

Change-Id: I452761a6189f50f93158f6de063d31c029bc2ed3

diff --git a/includes/specials/SpecialBotPasswords.php b/includes/specials/SpecialBotPasswords.php
index 47e3316..11357fb 100644 (file)
--- a/includes/specials/SpecialBotPasswords.php
+++ b/includes/specials/SpecialBotPasswords.php
@@ -84,7 +84,6 @@ class SpecialBotPasswords extends FormSpecialPage {
        }
 
        protected function getFormFields() {
-               $that = $this;
                $user = $this->getUser();
                $request = $this->getRequest();
 

diff --git a/includes/specials/SpecialChangeContentModel.php b/includes/specials/SpecialChangeContentModel.php
index d495120..bf44b42 100644 (file)
--- a/includes/specials/SpecialChangeContentModel.php
+++ b/includes/specials/SpecialChangeContentModel.php
@@ -68,7 +68,6 @@ class SpecialChangeContentModel extends FormSpecialPage {
        }
 
        protected function getFormFields() {
-               $that = $this;
                $fields = [
                        'pagetitle' => [
                                'type' => 'title',
@@ -91,10 +90,10 @@ class SpecialChangeContentModel extends FormSpecialPage {
                                'reason' => [
                                        'type' => 'text',
                                        'name' => 'reason',
-                                       'validation-callback' => function( $reason ) use ( $that ) {
+                                       'validation-callback' => function( $reason ) {
                                                $match = EditPage::matchSummarySpamRegex( $reason );
                                                if ( $match ) {
-                                                       return $that->msg( 'spamprotectionmatch', $match )->parse();
+                                                       return $this->msg( 'spamprotectionmatch', $match )->parse();
                                                }
 
                                                return true;