Merge "Use User::getDefaultOption() instead of $wgDefaultUserOptions"
authorAaron Schulz <aschulz@wikimedia.org>
Sun, 22 Jul 2012 09:45:18 +0000 (09:45 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sun, 22 Jul 2012 09:45:18 +0000 (09:45 +0000)
includes/User.php

index 76e8420..ca8ce8f 100644 (file)
@@ -2289,9 +2289,11 @@ class User {
                $this->loadOptions();
 
                // Explicitly NULL values should refer to defaults
-               global $wgDefaultUserOptions;
-               if( is_null( $val ) && isset( $wgDefaultUserOptions[$oname] ) ) {
-                       $val = $wgDefaultUserOptions[$oname];
+               if( is_null( $val ) ) {
+                       $defaultOption = self::getDefaultOption( $oname );
+                       if( !is_null( $defaultOption ) ) {
+                               $val = $defaultOption;
+                       }
                }
 
                $this->mOptions[$oname] = $val;