* (bug 23024) Special:ListFiles now escapes file names correctly

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 5144907..0dedf55 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -71,6 +71,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 21520) Anonymous previews now also gives a warning about not being 
   logged in (anonpreviewwarning).
 * (bug 22935) image/x-ms-bmp mime type added for BMP files
+* (bug 23024) Special:ListFiles now escapes file names correctly
 
 === API changes in 1.17 ===
 * (bug 22738) Allow filtering by action type on query=logevent

diff --git a/includes/specials/SpecialListfiles.php b/includes/specials/SpecialListfiles.php
index b933242..024f6f9 100644 (file)
--- a/includes/specials/SpecialListfiles.php
+++ b/includes/specials/SpecialListfiles.php
@@ -131,7 +131,7 @@ class ImageListPager extends TablePager {
                                if ( $imgfile === null ) $imgfile = wfMsg( 'imgfile' );
 
                                $name = $this->mCurrentRow->img_name;
-                               $link = $this->getSkin()->linkKnown( Title::makeTitle( NS_FILE, $name ), $value );
+                               $link = $this->getSkin()->linkKnown( Title::makeTitle( NS_FILE, $name ), htmlspecialchars( $value ) );
                                $image = wfLocalFile( $value );
                                $url = $image->getURL();
                                $download = Xml::element('a', array( 'href' => $url ), $imgfile );