ActiveUsersPager: Fix outer GROUP BY
authorBrad Jorsch <bjorsch@wikimedia.org>
Fri, 16 Aug 2019 17:57:51 +0000 (13:57 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Fri, 16 Aug 2019 17:57:51 +0000 (13:57 -0400)
MySQL doesn't care, but PG actually enforces rules about GROUP BY
columns.

Bug: T230618
Change-Id: If769db525bf53c906ad3e0e1d1a6e92194f622a8

includes/specials/pagers/ActiveUsersPager.php

index 368c6d1..7703e20 100644 (file)
@@ -155,7 +155,7 @@ class ActiveUsersPager extends UsersPager {
                                'user_id' => 'user_id',
                                'recentedits' => 'COUNT(rc_id)'
                        ],
-                       'options' => [ 'GROUP BY' => [ 'qcc_title' ] ],
+                       'options' => [ 'GROUP BY' => [ 'qcc_title', 'user_id' ] ],
                        'conds' => $conds,
                        'join_conds' => $jconds,
                ];