(bug 11474) Fix unintentional fall-through in math error handling

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index fcf9dab..1da6d9b 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -74,7 +74,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Fix namespace selection after submit of Special:Newpages
 * Make input form of Special:Newpages nicer for RTL wikis
 * (bug 11462) Fix typo in LanguageGetSpecialPageAliases hook name
-
+* (bug 11474) Fix unintentional fall-through in math error handling
 
 === API changes in 1.12 ===
 

diff --git a/includes/Math.php b/includes/Math.php
index 2771d04..cfed955 100644 (file)
--- a/includes/Math.php
+++ b/includes/Math.php
@@ -111,10 +111,17 @@ class MathRenderer {
                        } else {
                                $errbit = htmlspecialchars( substr($contents, 1) );
                                switch( $retval ) {
-                                       case 'E': $errmsg = $this->_error( 'math_lexing_error', $errbit );
-                                       case 'S': $errmsg = $this->_error( 'math_syntax_error', $errbit );
-                                       case 'F': $errmsg = $this->_error( 'math_unknown_function', $errbit );
-                                       default:  $errmsg = $this->_error( 'math_unknown_error', $errbit );
+                                       case 'E':
+                                               $errmsg = $this->_error( 'math_lexing_error', $errbit );
+                                               break;
+                                       case 'S':
+                                               $errmsg = $this->_error( 'math_syntax_error', $errbit );
+                                               break;
+                                       case 'F':
+                                               $errmsg = $this->_error( 'math_unknown_function', $errbit );
+                                               break;
+                                       default:
+                                               $errmsg = $this->_error( 'math_unknown_error', $errbit );
                                }
                        }