Merge "Convert SearchResultSet to typical iteration"

diff --combined RELEASE-NOTES-1.32
index b1f93f9,57952f5..cbbb48f
--- 1/RELEASE-NOTES-1.32
--- 2/RELEASE-NOTES-1.32
+++ b/RELEASE-NOTES-1.32
@@@ -158,8 -158,6 +158,8 @@@ because of Phabricator reports
    minor change to implement the toggle feature with CSS instead. To restore
    prior functionality, either explicitly load "jquery.mw-jump" in your skin
    or refer to T195256 for details on how to make the same change.
 +* Hook 'EditPageBeforeEditChecks' was removed;
 +  use 'EditPageGetCheckboxesDefinition' instead.
  
  === Deprecations in 1.32 ===
  * Use of a StartProfiler.php file is deprecated in favour of placing
@@@ -190,6 -188,13 +190,13 @@@
  * The ApiQueryContributions class has been renamed to ApiQueryUserContribs.
  * The XMPInfo, XMPReader, and XMPValidate classes have been deprecated in favor
    of the namespaced classes provided by the wikimedia/xmp-reader library.
+ * SearchResultSet::{next,rewind} are deprecated. Calling code should
+   use foreach on the SearchResultSet, or the extractResults method. Extending
+   code should override extractResults.
+ * Instantiating SearchResultSet directly is deprecated. SearchEngine
+   implementations must subclass SearchResultSet for their purposes.
+ * SearchResult::setExtensionData argument has been changed from accepting an
+   array to accepting a Closure that returns the array when called.
  * Class CryptRand, everything in MWCryptRand except generateHex() and function
    MediaWikiServices::getCryptRand() are deprecated, use random_bytes() to
    generate cryptographically secure random byte sequences.