Revert more visibility changes in HistoryBlob.php
authorKevin Israel <pleasestand@live.com>
Sun, 25 May 2014 13:12:00 +0000 (09:12 -0400)
committerKevin Israel <pleasestand@live.com>
Sun, 25 May 2014 21:09:40 +0000 (17:09 -0400)
This follows-up bebcf2c58381, which only fixed DiffHistoryBlob.

MediaWiki will fail to load some revisions if the following properties
do not unserialize correctly:

* HistoryBlobStub::$mOldId
* HistoryBlobStub::$mHash
* HistoryBlobCurStub::$mCurId

Visibility of HistoryBlobStub::$mRef is also restored; though the
property's value does not appear to be used after unserialization,
the property is nevertheless a serialized property.

Bug: 65665
Change-Id: I2724d15f9206d66d615d020117e60bb772048c19

includes/HistoryBlob.php

index 06e5ecc..d0cae36 100644 (file)
@@ -197,13 +197,13 @@ class HistoryBlobStub {
        protected static $blobCache = array();
 
        /** @var int */
-       protected $mOldId;
+       public $mOldId;
 
        /** @var string */
-       protected $mHash;
+       public $mHash;
 
        /** @var  */
-       protected $mRef;
+       public $mRef;
 
        /**
         * @param string $hash The content hash of the text
@@ -313,7 +313,7 @@ class HistoryBlobStub {
  */
 class HistoryBlobCurStub {
        /** @var int */
-       private $mCurId;
+       public $mCurId;
 
        /**
         * @param int $curid The cur_id pointed to