Fix warning on QUnit modules without dependencies
authorElliott Eggleston <ejegg@ejegg.com>
Wed, 27 Feb 2019 15:48:58 +0000 (10:48 -0500)
committerElliott Eggleston <ejegg@ejegg.com>
Wed, 27 Feb 2019 15:48:58 +0000 (10:48 -0500)
Check if $module['dependencies'] is set before checking whether
it's a string.

Change-Id: I9ece83d4ec92d0d3a41a1c6863492e646f011eab

includes/resourceloader/ResourceLoader.php

index 4158082..3d13350 100644 (file)
@@ -424,7 +424,7 @@ class ResourceLoader implements LoggerAwareInterface {
                // Add the QUnit testrunner as implicit dependency to extension test suites.
                foreach ( $testModules['qunit'] as &$module ) {
                        // Shuck any single-module dependency as an array
-                       if ( is_string( $module['dependencies'] ) ) {
+                       if ( isset( $module['dependencies'] ) && is_string( $module['dependencies'] ) ) {
                                $module['dependencies'] = [ $module['dependencies'] ];
                        }