Fixed sloppy usage of Database::selectField() in getPreviousRevisionID() and getNextR...
authorTim Starling <tstarling@users.mediawiki.org>
Fri, 23 May 2008 09:00:08 +0000 (09:00 +0000)
committerTim Starling <tstarling@users.mediawiki.org>
Fri, 23 May 2008 09:00:08 +0000 (09:00 +0000)
includes/Title.php

index fa80f68..0a227d5 100644 (file)
@@ -2932,8 +2932,13 @@ class Title {
        public function getPreviousRevisionID( $revision, $flags=0 ) {
                $db = ($flags & GAID_FOR_UPDATE) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE );
                return $db->selectField( 'revision', 'rev_id',
-                       'rev_page=' . intval( $this->getArticleId($flags) ) .
-                       ' AND rev_id<' . intval( $revision ) . ' ORDER BY rev_id DESC' );
+                       array(
+                               'rev_page' => $this->getArticleId($flags),
+                               'rev_id < ' . intval( $revision )
+                       ),
+                       __METHOD__,
+                       array( 'ORDER BY' => 'rev_id DESC' )
+               );
        }
 
        /**
@@ -2946,8 +2951,13 @@ class Title {
        public function getNextRevisionID( $revision, $flags=0 ) {
                $db = ($flags & GAID_FOR_UPDATE) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE );
                return $db->selectField( 'revision', 'rev_id',
-                       'rev_page=' . intval( $this->getArticleId($flags) ) .
-                       ' AND rev_id>' . intval( $revision ) . ' ORDER BY rev_id' );
+                       array(
+                               'rev_page' => $this->getArticleId($flags),
+                               'rev_id > ' . intval( $revision )
+                       ),
+                       __METHOD__,
+                       array( 'ORDER BY' => 'rev_id' )
+               );
        }
 
        /**