Remove a TODO from ApiMove and add a FIXME to SpecialMovepage
authorRoan Kattouw <catrope@users.mediawiki.org>
Mon, 9 Feb 2009 15:15:49 +0000 (15:15 +0000)
committerRoan Kattouw <catrope@users.mediawiki.org>
Mon, 9 Feb 2009 15:15:49 +0000 (15:15 +0000)
includes/api/ApiMove.php
includes/specials/SpecialMovepage.php

index 1045f3e..c3a5e7d 100644 (file)
@@ -107,7 +107,6 @@ class ApiMove extends ApiBase {
                        $r['subpages'] = $this->moveSubpages($fromTitle, $toTitle,
                                        $params['reason'], $params['noredirect']);
                        $this->getResult()->setIndexedTagName($r['subpages'], 'subpage');
-                       // TODO: Should we move talk subpages if moving the talk page failed?
                        if($params['movetalk'])
                        {
                                $r['subpages-talk'] = $this->moveSubpages($fromTalk, $toTalk,
index 7e6f101..7acfd25 100644 (file)
@@ -378,6 +378,8 @@ class MovePageForm {
                # would mean that you couldn't move them back in one operation, which
                # is bad.  FIXME: A specific error message should be given in this
                # case.
+               
+               // FIXME: Use Title::moveSubpages() here
                $dbr = wfGetDB( DB_MASTER );
                if( $this->moveSubpages && (
                        MWNamespace::hasSubpages( $nt->getNamespace() ) || (