* (bug 9044) Send a comment with action=raw pages in CSS/JS output mode

  to work around IE/Mac bug where empty pages time out verrrrryyyyy slowly,
  particularly with new keepalive-friendly HTTP on Wikipedia

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 4dd7855..24399ba 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -217,6 +217,9 @@ lighter making things easier to read.
   on a previously fixed attack vector was discovered by Moshe BA from BugSec:
   http://www.bugsec.com/articles.php?Security=24
 * Trackback responses now specify XML content type
+* (bug 9044) Send a comment with action=raw pages in CSS/JS output mode
+  to work around IE/Mac bug where empty pages time out verrrrryyyyy slowly,
+  particularly with new keepalive-friendly HTTP on Wikipedia
 
 
 == Languages updated ==

diff --git a/includes/RawPage.php b/includes/RawPage.php
index 0813018..2b2a5ce 100644 (file)
--- a/includes/RawPage.php
+++ b/includes/RawPage.php
@@ -191,6 +191,20 @@ class RawPage {
                        header( "HTTP/1.0 404 Not Found" );
                }
                
+               // Special-case for empty CSS/JS
+               //
+               // Internet Explorer for Mac handles empty files badly;
+               // particularly so when keep-alive is active. It can lead
+               // to long timeouts as it seems to sit there waiting for
+               // more data that never comes.
+               //
+               // Give it a comment...
+               if( strlen( $text ) == 0 &&
+                       ($this->mContentType == 'text/css' ||
+                               $this->mContentType == 'text/javascript' ) ) {
+                       return "/* Empty */";
+               }
+               
                return $this->parseArticleText( $text );
        }