Simplify Xml::encodeJsCall

Change-Id: Idf2838a1b32170ca6336eb4a67f16cd3335218f9

diff --git a/includes/Xml.php b/includes/Xml.php
index 67f3658..d5e9189 100644 (file)
--- a/includes/Xml.php
+++ b/includes/Xml.php
@@ -682,22 +682,11 @@ class Xml {
         * @return string
         */
        public static function encodeJsCall( $name, $args ) {
-               $s = "$name(";
-               $first = true;
-
-               foreach ( $args as $arg ) {
-                       if ( $first ) {
-                               $first = false;
-                       } else {
-                               $s .= ', ';
-                       }
-
-                       $s .= Xml::encodeJsVar( $arg );
+               foreach ( $args as &$arg ) {
+                       $arg = Xml::encodeJsVar( $arg );
                }
 
-               $s .= ");\n";
-
-               return $s;
+               return "$name(" . implode( ', ', $args ) . ");\n";
        }
 
        /**