Skip missed dependencies in ResourcesTest::testUnsatisfiableDependencies
authorumherirrender <umherirrender_de.wp@web.de>
Sat, 14 Feb 2015 12:47:23 +0000 (13:47 +0100)
committerUmherirrender <umherirrender_de.wp@web.de>
Sat, 21 Feb 2015 23:08:00 +0000 (23:08 +0000)
When a dependency is missing the test
ResourcesTest::testUnsatisfiableDependencies gives a error because of
Undefined index and stops further checks. Skip this situation because
the existing test ResourcesTest::testMissingDependencies already gives a
failure with a better explanation in this situation.

Change-Id: I71a88551df67d52ea96bf7283b5de892692f9336

tests/phpunit/structure/ResourcesTest.php

index 2396ea2..16a9f3a 100644 (file)
@@ -91,6 +91,10 @@ class ResourcesTest extends MediaWikiTestCase {
                foreach ( $data['modules'] as $moduleName => $module ) {
                        $moduleTargets = $module->getTargets();
                        foreach ( $module->getDependencies() as $dep ) {
+                               if ( !isset( $data['modules'][$dep] ) ) {
+                                       // Missing dependencies reported by testMissingDependencies
+                                       continue;
+                               }
                                $targets = $data['modules'][$dep]->getTargets();
                                foreach ( $moduleTargets as $moduleTarget ) {
                                        $this->assertContains(