dépôts
/
lhc
/
web
/
wiklou.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
4bd15ed
)
Fix unused variables
author
Sam Reed
<reedy@users.mediawiki.org>
Fri, 13 May 2011 16:16:44 +0000
(16:16 +0000)
committer
Sam Reed
<reedy@users.mediawiki.org>
Fri, 13 May 2011 16:16:44 +0000
(16:16 +0000)
Decapitalise False
includes/Article.php
patch
|
blob
|
history
includes/ZipDirectoryReader.php
patch
|
blob
|
history
skins/Standard.php
patch
|
blob
|
history
tests/selenium/suites/AddContentToNewPageTestCase.php
patch
|
blob
|
history
diff --git
a/includes/Article.php
b/includes/Article.php
index
b3cd3b4
..
4f1d546
100644
(file)
--- a/
includes/Article.php
+++ b/
includes/Article.php
@@
-1733,7
+1733,7
@@
class Article {
* or else the record will be left in a funky state.
* Best if all done inside a transaction.
*
* or else the record will be left in a funky state.
* Best if all done inside a transaction.
*
- * @param $dbw Database
+ * @param $dbw Database
Base
* @return int The newly created page_id key, or false if the title already existed
* @private
*/
* @return int The newly created page_id key, or false if the title already existed
* @private
*/
diff --git
a/includes/ZipDirectoryReader.php
b/includes/ZipDirectoryReader.php
index
eb75b68
..
d21cf3b
100644
(file)
--- a/
includes/ZipDirectoryReader.php
+++ b/
includes/ZipDirectoryReader.php
@@
-16,8
+16,8
@@
class ZipDirectoryReader {
* suspicious or ambiguous input, instead of emulating some standard
* behaviour.
*
* suspicious or ambiguous input, instead of emulating some standard
* behaviour.
*
- * @param $fileName The archive file name
- * @param $callback
The callback function. It will be called for each file
+ * @param $fileName
string
The archive file name
+ * @param $callback
Array The callback function. It will be called for each file
* with a single associative array each time, with members:
*
* - name: The file name. Directories conventionally have a trailing
* with a single associative array each time, with members:
*
* - name: The file name. Directories conventionally have a trailing
@@
-27,7
+27,7
@@
class ZipDirectoryReader {
*
* - size: The uncompressed file size
*
*
* - size: The uncompressed file size
*
- * @param $options An associative array of read options, with the option
+ * @param $options A
rray A
n associative array of read options, with the option
* name in the key. This may currently contain:
*
* - zip64: If this is set to true, then we will emulate a
* name in the key. This may currently contain:
*
* - zip64: If this is set to true, then we will emulate a
@@
-44,7
+44,7
@@
class ZipDirectoryReader {
* valid ZIP64 file, and working out what non-ZIP64 readers will make
* of such a file is not trivial.
*
* valid ZIP64 file, and working out what non-ZIP64 readers will make
* of such a file is not trivial.
*
- * @return
A
Status object. The following fatal errors are defined:
+ * @return Status object. The following fatal errors are defined:
*
* - zip-file-open-error: The file could not be opened.
*
*
* - zip-file-open-error: The file could not be opened.
*
@@
-119,6
+119,8
@@
class ZipDirectoryReader {
/**
* Read the directory according to settings in $this.
/**
* Read the directory according to settings in $this.
+ *
+ * @return Status
*/
function execute() {
$this->file = fopen( $this->fileName, 'r' );
*/
function execute() {
$this->file = fopen( $this->fileName, 'r' );
diff --git
a/skins/Standard.php
b/skins/Standard.php
index
bb540ae
..
41a796b
100644
(file)
--- a/
skins/Standard.php
+++ b/
skins/Standard.php
@@
-120,7
+120,7
@@
class StandardTemplate extends LegacyTemplate {
unset( $bar['TOOLBOX'] );
$barnumber = 1;
unset( $bar['TOOLBOX'] );
$barnumber = 1;
- foreach ( $bar as $
heading => $
browseLinks ) {
+ foreach ( $bar as $browseLinks ) {
if ( $barnumber > 1 ) {
$s .= "\n<hr class='sep' />";
}
if ( $barnumber > 1 ) {
$s .= "\n<hr class='sep' />";
}
diff --git
a/tests/selenium/suites/AddContentToNewPageTestCase.php
b/tests/selenium/suites/AddContentToNewPageTestCase.php
index
4965b52
..
72e75e1
100644
(file)
--- a/
tests/selenium/suites/AddContentToNewPageTestCase.php
+++ b/
tests/selenium/suites/AddContentToNewPageTestCase.php
@@
-114,8
+114,8
@@
class AddContentToNewPageTestCase extends SeleniumTestCase {
// Add level 2 headline and verify output in the preview
public function testAddLevel2HeadLine() {
// Add level 2 headline and verify output in the preview
public function testAddLevel2HeadLine() {
- $blnElementPresent =
F
alse;
- $blnTextPresent =
F
alse;
+ $blnElementPresent =
f
alse;
+ $blnTextPresent =
f
alse;
$this->getExistingPage();
$this->clickEditLink();
$this->loadWikiEditor();
$this->getExistingPage();
$this->clickEditLink();
$this->loadWikiEditor();