- User::getOption() doesn't return bool, as a result all signitures were
fancy, just use User::getBoolOption()
* Fixed stuff introduced in revision 1.564 by rob
- User::getOption() output is pre-trimmed, no need for double-trimming
- == => ===
- the ternary op takes precedence over =, -()
global $wgContLang;
$username = $user->getName();
global $wgContLang;
$username = $user->getName();
- $nickname = trim( $user->getOption( 'nickname' ) );
- $nickname = ( $nickname == '' ? $username : $nickname );
+ $nickname = $user->getOption( 'nickname' );
+ $nickname = $nickname === '' ? $username : $nickname;
- if( $user->getOption( 'fancysig' ) !== false ) {
+ if( $user->getBoolOption( 'fancysig' ) !== false ) {
# Sig. might contain markup; validate this
if( $this->validateSig( $nickname ) !== false ) {
# Validated; clean up (if needed) and return it
# Sig. might contain markup; validate this
if( $this->validateSig( $nickname ) !== false ) {
# Validated; clean up (if needed) and return it