Recalculate user default options for each test
authorErik Bernhardson <ebernhardson@wikimedia.org>
Wed, 27 Mar 2019 23:55:09 +0000 (16:55 -0700)
committerErik Bernhardson <ebernhardson@wikimedia.org>
Thu, 28 Mar 2019 18:12:17 +0000 (11:12 -0700)
commitfe2cb4efc64bad506294adeea516efe70368a9b1
treea902e090648dd3d4949a1af62f87893593b0b0c8
parent4c52b3b92dbf3fdff2f712dadbed7785d9c17b17
Recalculate user default options for each test

Statically caching the default user options means tests that change
the inputs, and expect to see the result in their code, are foiled
and the reasons shrowded in mystery.  Recalculate default user options
on a per test basis.

Change-Id: I9075cc9c05546a857850e8b4b4dea9f51873451b
includes/user/User.php
tests/phpunit/MediaWikiTestCase.php
tests/phpunit/includes/specials/SpecialWatchlistTest.php