dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d7c4e65) | patch
Avoid INSERT..SELECT in LocalFileDeleteBatch
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 23 Aug 2016 17:10:48 +0000 (10:10 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 23 Aug 2016 17:10:52 +0000 (10:10 -0700)
commite2c03a8afd4fff0b364c8d64f1aca8c97dde9cfa
treeb6de7a1237b8e9e743246a836eb5125eda9b26c9tree | snapshot
parentd7c4e65fddc7a737395cb1dbaedb4d51eff3cc43commit | diff
Avoid INSERT..SELECT in LocalFileDeleteBatch

That construct has poor locking characteristics in terms of
auto-inc columns as well as not allowing such inserts concurrently
for statement-based replication. Also, the INSERT..SELECT did not
have an ORDER BY, which could lead to fa_id drift with statement
based replication.

Change-Id: Iaacb75d9931b4cd24b70bdcaadd0e3979c7e9c90
includes/filerepo/file/LocalFile.php diff | blob | history
Wiklou, le Wiki du Wiklou