Make "/*@noflip*/ /*@embed*/" annotation work
authorBartosz Dziewoński <matma.rex@gmail.com>
Mon, 18 Aug 2014 15:32:22 +0000 (17:32 +0200)
committerBartosz Dziewoński <matma.rex@gmail.com>
Mon, 18 Aug 2014 15:40:51 +0000 (17:40 +0200)
commit2d842f14250646475b5c2ffa2fe4f5a131f94236
tree8576a7bc3220e00956bd6dbe93771a2e453972f9
parent90c13419f0899218ac5437e6102658dd6e73b63f
Make "/*@noflip*/ /*@embed*/" annotation work

To do it, just remove /*@noflip*/ annotations in CSSJanus after
we're done processing. They are not needed anymore and some obscure
interactions with CSSMin logic for preserving comments caused
`/*@noflip*/ /*@embed*/ background-image: url(…)` not to work
correctly (it would not be embedded).

This also requires us to always do CSSJanus processing, even when we
don't need flipping, to consistently handle the annotations.
I'm not entirely sure if this is worth it, but I still greatly prefer
doing it to documenting this stupid limitation. :)

Bug: 69698
Change-Id: I311b12b08b2dff9d45efb584db08cf4a11318f59
includes/OutputPage.php
includes/libs/CSSJanus.php
includes/resourceloader/ResourceLoaderFileModule.php
includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php
includes/resourceloader/ResourceLoaderWikiModule.php
tests/phpunit/data/css/expected.css
tests/phpunit/data/css/test.css
tests/phpunit/data/less/module/styles.css
tests/phpunit/includes/libs/CSSJanusTest.php
tests/phpunit/includes/resourceloader/ResourceLoaderTest.php