dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9027c35) | patch
* (bug 29426) Fix wrong use of Block::load's second parameter in BlockTest
authorBrion Vibber <brion@users.mediawiki.org>
Thu, 16 Jun 2011 17:58:26 +0000 (17:58 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Thu, 16 Jun 2011 17:58:26 +0000 (17:58 +0000)
commit13b1da185e9d340ce4c6c38f945c7da37923e6e8
treec1a5bf70faf925512b95a4f809f8360ea73b14c1tree | snapshot
parent9027c35dcab45e7d35d979f3f1059d863943a689commit | diff
* (bug 29426) Fix wrong use of Block::load's second parameter in BlockTest

It was accidentally passing a username where it should have passed a user ID, causing PostgreSQL's stricter comparisons to fail, while MySQL's allowed it to run without complaint but returned bad results.
Of course that bug got hidden by the test.... testing the wrong thing... :)

Now correctly loads using the user id instead of name, checks the proper return values, and actually compares the right object.
tests/phpunit/includes/BlockTest.php diff | blob | history
Wiklou, le Wiki du Wiklou