Refactor deferrable updates into classes & interfaces, also add helper method for...
[lhc/web/wiklou.git] / includes / Wiki.php
index 5a9ee41..ca8584b 100644 (file)
@@ -80,7 +80,9 @@ class MediaWiki {
                        $ret = Title::newFromURL( $title );
                        // check variant links so that interwiki links don't have to worry
                        // about the possible different language variants
-                       if ( count( $wgContLang->getVariants() ) > 1 && !is_null( $ret ) && $ret->getArticleID() == 0 ){
+                       if ( count( $wgContLang->getVariants() ) > 1
+                               && !is_null( $ret ) && $ret->getArticleID() == 0 )
+                       {
                                $wgContLang->findVariantLink( $title, $ret );
                        }
                }
@@ -96,9 +98,10 @@ class MediaWiki {
                        }
                }
 
-               if( $ret === null || ( $ret->getDBkey() == '' && $ret->getInterwiki() == '' ) ){
-                       $ret = new BadTitle;
+               if ( $ret === null || ( $ret->getDBkey() == '' && $ret->getInterwiki() == '' ) ) {
+                       $ret = SpecialPage::getTitleFor( 'Badtitle' );
                }
+
                return $ret;
        }
 
@@ -124,7 +127,7 @@ class MediaWiki {
         *
         * @return void
         */
-       public function performRequest() {
+       private function performRequest() {
                global $wgServer, $wgUsePathInfo;
 
                wfProfileIn( __METHOD__ );
@@ -144,7 +147,8 @@ class MediaWiki {
                        array( &$title, null, &$output, &$user, $request, $this ) );
 
                // Invalid titles. Bug 21776: The interwikis must redirect even if the page name is empty.
-               if ( $title instanceof BadTitle ) {
+               if ( is_null( $title ) || ( ( $title->getDBkey() == '' ) && ( $title->getInterwiki() == '' ) ) ) {
+                       $this->context->title = SpecialPage::getTitleFor( 'Badtitle' );
                        throw new ErrorPageError( 'badtitle', 'badtitletext' );
                // If the user is not logged in, the Namespace:title of the article must be in
                // the Read array in order for the user to see it. (We have to check here to
@@ -162,18 +166,21 @@ class MediaWiki {
                                $url = $title->getFullURL( $query );
                        }
                        // Check for a redirect loop
-                       if ( !preg_match( '/^' . preg_quote( $wgServer, '/' ) . '/', $url ) && $title->isLocal() ) {
+                       if ( !preg_match( '/^' . preg_quote( $wgServer, '/' ) . '/', $url )
+                               && $title->isLocal() )
+                       {
                                // 301 so google et al report the target as the actual url.
                                $output->redirect( $url, 301 );
                        } else {
-                               $this->context->setTitle( new BadTitle );
+                               $this->context->setTitle( SpecialPage::getTitleFor( 'Badtitle' ) );
                                wfProfileOut( __METHOD__ );
                                throw new ErrorPageError( 'badtitle', 'badtitletext' );
                        }
                // Redirect loops, no title in URL, $wgUsePathInfo URLs, and URLs with a variant
                } elseif ( $request->getVal( 'action', 'view' ) == 'view' && !$request->wasPosted()
-                       && ( $request->getVal( 'title' ) === null || $title->getPrefixedDBKey() != $request->getVal( 'title' ) )
-                       && !count( array_diff( array_keys( $request->getValues() ), array( 'action', 'title' ) ) ) )
+                       && ( $request->getVal( 'title' ) === null ||
+                               $title->getPrefixedDBKey() != $request->getVal( 'title' ) )
+                       && !count( $request->getValueNames( array( 'action', 'title' ) ) ) )
                {
                        if ( $title->getNamespace() == NS_SPECIAL ) {
                                list( $name, $subpage ) = SpecialPageFactory::resolveAlias( $title->getDBkey() );
@@ -181,7 +188,7 @@ class MediaWiki {
                                        $title = SpecialPage::getTitleFor( $name, $subpage );
                                }
                        }
-                       $targetUrl = $title->getFullURL();
+                       $targetUrl = wfExpandUrl( $title->getFullURL(), PROTO_CURRENT );
                        // Redirect to canonical url, make it a 301 to allow caching
                        if ( $targetUrl == $request->getFullRequestURL() ) {
                                $message = "Redirect loop detected!\n\n" .
@@ -222,7 +229,7 @@ class MediaWiki {
                                /**
                                 * $wgArticle is deprecated, do not use it. This will possibly be removed
                                 * entirely in 1.20 or 1.21
-                                * @deprecated since 1.19
+                                * @deprecated since 1.18
                                 */
                                global $wgArticle;
                                $wgArticle = $article;
@@ -247,7 +254,7 @@ class MediaWiki {
        /**
         * Create an Article object of the appropriate class for the given page.
         *
-        * @deprecated in 1.19; use Article::newFromTitle() instead
+        * @deprecated in 1.18; use Article::newFromTitle() instead
         * @param $title Title
         * @param $context RequestContext
         * @return Article object
@@ -257,7 +264,7 @@ class MediaWiki {
        }
 
        /**
-        * Returns the action that will be executed, not necesserly the one passed
+        * Returns the action that will be executed, not necessarily the one passed
         * passed through the "action" parameter. Actions disabled in
         * $wgDisabledActions will be replaced by "nosuchaction"
         *
@@ -353,6 +360,7 @@ class MediaWiki {
                                $this->context->setTitle( $article->getTitle() );
                        }
                }
+
                wfProfileOut( __METHOD__ );
                return $article;
        }
@@ -369,7 +377,7 @@ class MediaWiki {
                // Output everything!
                $this->context->getOutput()->output();
                // Do any deferred jobs
-               wfDoUpdates( 'commit' );
+               DeferredUpdates::doUpdates( 'commit' );
                $this->doJobs();
                wfProfileOut( __METHOD__ );
        }
@@ -426,7 +434,7 @@ class MediaWiki {
         *
         * @param $article Article
         */
-       private function performAction( Article $article ) {
+       private function performAction( Page $article ) {
                global $wgSquidMaxage, $wgUseExternalEditor;
 
                wfProfileIn( __METHOD__ );
@@ -446,7 +454,7 @@ class MediaWiki {
                $act = $this->getAction();
 
                $action = Action::factory( $act, $article );
-               if( $action instanceof Action ){
+               if ( $action instanceof Action ) {
                        $action->show();
                        wfProfileOut( __METHOD__ );
                        return;
@@ -464,8 +472,6 @@ class MediaWiki {
                                wfProfileOut( __METHOD__ . '-raw' );
                                break;
                        case 'delete':
-                       case 'revert':
-                       case 'rollback':
                        case 'protect':
                        case 'unprotect':
                        case 'render':
@@ -484,12 +490,16 @@ class MediaWiki {
                                        $section = $request->getVal( 'section' );
                                        $oldid = $request->getVal( 'oldid' );
                                        if ( !$wgUseExternalEditor || $act == 'submit' || $internal ||
-                                          $section || $oldid || ( !$user->getOption( 'externaleditor' ) && !$external ) ) {
+                                          $section || $oldid ||
+                                          ( !$user->getOption( 'externaleditor' ) && !$external ) )
+                                       {
                                                $editor = new EditPage( $article );
                                                $editor->submit();
-                                       } elseif ( $wgUseExternalEditor && ( $external || $user->getOption( 'externaleditor' ) ) ) {
+                                       } elseif ( $wgUseExternalEditor
+                                               && ( $external || $user->getOption( 'externaleditor' ) ) )
+                                       {
                                                $mode = $request->getVal( 'mode' );
-                                               $extedit = new ExternalEdit( $article, $mode );
+                                               $extedit = new ExternalEdit( $article->getTitle(), $mode );
                                                $extedit->edit();
                                        }
                                }
@@ -513,7 +523,7 @@ class MediaWiki {
         * Run the current MediaWiki instance
         * index.php just calls this
         */
-       function run() {
+       public function run() {
                try {
                        $this->checkMaxLag( true );
                        $this->main();
@@ -531,7 +541,7 @@ class MediaWiki {
         * script execution. False to return the result as a boolean.
         * @return boolean True if we passed the check, false if we surpass the maxlag
         */
-       function checkMaxLag( $abort ) {
+       private function checkMaxLag( $abort ) {
                global $wgShowHostnames;
 
                wfProfileIn( __METHOD__ );
@@ -541,10 +551,11 @@ class MediaWiki {
                        list( $host, $lag ) = $lb->getMaxLag();
                        if ( $lag > $maxLag ) {
                                if ( $abort ) {
-                                       header( 'HTTP/1.1 503 Service Unavailable' );
-                                       header( 'Retry-After: ' . max( intval( $maxLag ), 5 ) );
-                                       header( 'X-Database-Lag: ' . intval( $lag ) );
-                                       header( 'Content-Type: text/plain' );
+                                       $resp = $this->context->getRequest()->response();
+                                       $resp->header( 'HTTP/1.1 503 Service Unavailable' );
+                                       $resp->header( 'Retry-After: ' . max( intval( $maxLag ), 5 ) );
+                                       $resp->header( 'X-Database-Lag: ' . intval( $lag ) );
+                                       $resp->header( 'Content-Type: text/plain' );
                                        if( $wgShowHostnames ) {
                                                echo "Waiting for $host: $lag seconds lagged\n";
                                        } else {
@@ -554,8 +565,9 @@ class MediaWiki {
 
                                wfProfileOut( __METHOD__ );
 
-                               if ( !$abort )
+                               if ( !$abort ) {
                                        return false;
+                               }
                                exit;
                        }
                }
@@ -563,7 +575,7 @@ class MediaWiki {
                return true;
        }
 
-       function main() {
+       private function main() {
                global $wgUseFileCache, $wgTitle, $wgUseAjax;
 
                wfProfileIn( __METHOD__ );
@@ -571,6 +583,7 @@ class MediaWiki {
                # Set title from request parameters
                $wgTitle = $this->getTitle();
                $action = $this->getAction();
+               $user = $this->context->getUser();
 
                # Send Ajax requests to the Ajax dispatcher.
                if ( $wgUseAjax && $action == 'ajax' ) {
@@ -589,12 +602,13 @@ class MediaWiki {
                                $cache = new HTMLFileCache( $wgTitle, $action );
                                if ( $cache->isFileCacheGood( /* Assume up to date */ ) ) {
                                        /* Check incoming headers to see if client has this cached */
-                                       if ( !$this->context->getOutput()->checkLastModified( $cache->fileCacheTime() ) ) {
+                                       $timestamp = $cache->fileCacheTime();
+                                       if ( !$this->context->getOutput()->checkLastModified( $timestamp ) ) {
                                                $cache->loadFromFileCache();
                                        }
                                        # Do any stats increment/watchlist stuff
-                                       $article = Article::newFromTitle( $wgTitle, $this->context );
-                                       $article->viewUpdates();
+                                       $article = WikiPage::factory( $wgTitle );
+                                       $article->doViewUpdates( $user );
                                        # Tell OutputPage that output is taken care of
                                        $this->context->getOutput()->disable();
                                        wfProfileOut( 'main-try-filecache' );