fixing r65339 which broke Upload when file dest was undefined

[lhc/web/wiklou.git] / includes / JobQueue.php

diff --git a/includes/JobQueue.php b/includes/JobQueue.php
index 4ab5eac..3ae4b8e 100644 (file)
--- a/includes/JobQueue.php
+++ b/includes/JobQueue.php
@@ -76,7 +76,8 @@ abstract class Job {
                $namespace = $row->job_namespace;
                $dbkey = $row->job_title;
                $title = Title::makeTitleSafe( $namespace, $dbkey );
-               $job = Job::factory( $row->job_cmd, $title, Job::extractBlob( $row->job_params ), $row->job_id );
+               $job = Job::factory( $row->job_cmd, $title, Job::extractBlob( $row->job_params ),
+                       $row->job_id );
 
                $dbw->delete( 'job', $job->insertFields(), __METHOD__ );
                $dbw->commit();
@@ -260,6 +261,7 @@ abstract class Job {
 
        /**
         * Insert a single job into the queue.
+        * @return bool true on success
         */
        function insert() {
                $fields = $this->insertFields();
@@ -272,7 +274,7 @@ abstract class Job {
                                return;
                        }
                }
-               $dbw->insert( 'job', $fields, __METHOD__ );
+               return $dbw->insert( 'job', $fields, __METHOD__ );
        }
 
        protected function insertFields() {