From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 8 Aug 2019 00:29:28 +0000 (-0700)
Subject: rdbms: add some more comments to DatabaseDomain
X-Git-Tag: 1.34.0-rc.0~637^2
X-Git-Url: http://git.cyclocoop.org/wiki/Template:Dynamic?a=commitdiff_plain;h=f0e86c8856fa5f6ef9607a45a4e849f65309626c;p=lhc%2Fweb%2Fwiklou.git

rdbms: add some more comments to DatabaseDomain

Change-Id: Iee407028a2f3c7eb6497a73d57c7baa093246217
---

diff --git a/includes/libs/rdbms/database/domain/DatabaseDomain.php b/includes/libs/rdbms/database/domain/DatabaseDomain.php
index 5698cf824d..3ceb339b76 100644
--- a/includes/libs/rdbms/database/domain/DatabaseDomain.php
+++ b/includes/libs/rdbms/database/domain/DatabaseDomain.php
@@ -23,7 +23,19 @@ namespace Wikimedia\Rdbms;
 use InvalidArgumentException;
 
 /**
- * Class to handle database/prefix specification for IDatabase domains
+ * Class to handle database/schema/prefix specifications for IDatabase
+ *
+ * The components of a database domain are defined as follows:
+ *   - database: name of a server-side collection of schemas that is client-selectable
+ *   - schema: name of a server-side collection of tables within the given database
+ *   - prefix: table name prefix of an application-defined table collection
+ *
+ * If an RDBMS does not support server-side collections of table collections (schemas) then
+ * the schema component should be null and the "database" component treated as a collection
+ * of exactly one table collection (the implied schema for that "database").
+ *
+ * The above criteria should determine how components should map to RDBMS specific keywords
+ * rather than "database"/"schema" always mapping to "DATABASE"/"SCHEMA" as used by the RDBMS.
  */
 class DatabaseDomain {
 	/** @var string|null */