From b07eb85267fc61adfe75d8af48e9272c46e67a4b Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Tue, 31 May 2016 21:25:18 -0700 Subject: [PATCH] Make $url parameter to Parser::getExternalLinkAttribs() required All callers in Gerrit pass $url in. Change-Id: I36246f6510db414dcc7023f8779796c060c3eba5 --- includes/parser/Parser.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php index 17098f7cd3..66298b00f3 100644 --- a/includes/parser/Parser.php +++ b/includes/parser/Parser.php @@ -1882,11 +1882,11 @@ class Parser { * (depending on configuration, namespace, and the URL's domain) and/or a * target attribute (depending on configuration). * - * @param string|bool $url Optional URL, to extract the domain from for rel => + * @param string $url URL to extract the domain from for rel => * nofollow if appropriate * @return array Associative array of HTML attributes */ - public function getExternalLinkAttribs( $url = false ) { + public function getExternalLinkAttribs( $url ) { $attribs = []; $rel = self::getExternalLinkRel( $url, $this->mTitle ); -- 2.20.1