From aab4d394effc79c2de98ebea4bb1db101b390d8a Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Mon, 1 Apr 2013 19:18:15 +0200 Subject: [PATCH] Remove unneeded else{} and return Else action was default. Returned the result of a void function. Change-Id: I9ddf051ded0228dd3dfdfe9312f467d9c57f1716 --- includes/api/ApiUpload.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/api/ApiUpload.php b/includes/api/ApiUpload.php index 2dcf39204d..719032f2ce 100644 --- a/includes/api/ApiUpload.php +++ b/includes/api/ApiUpload.php @@ -444,9 +444,9 @@ class ApiUpload extends ApiBase { $verification = $this->mUpload->verifyUpload(); if ( $verification['status'] === UploadBase::OK ) { return; - } else { - return $this->checkVerification( $verification ); } + + $this->checkVerification( $verification ); } /** @@ -455,7 +455,7 @@ class ApiUpload extends ApiBase { protected function checkVerification( array $verification ) { global $wgFileExtensions; - // TODO: Move them to ApiBase's message map + // @todo Move them to ApiBase's message map switch( $verification['status'] ) { // Recoverable errors case UploadBase::MIN_LENGTH_PARTNAME: -- 2.20.1