From a21d6823c1677b3a0c6d980b9912dca9632df70e Mon Sep 17 00:00:00 2001 From: Leo Koppelkamm Date: Wed, 20 Apr 2011 15:30:26 +0000 Subject: [PATCH] Followup to r86056 per CR: No need to keep jQuery object, just set it to boolean true --- resources/mediawiki.action/mediawiki.action.history.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/resources/mediawiki.action/mediawiki.action.history.js b/resources/mediawiki.action/mediawiki.action.history.js index a03a7426d7..98a97cd0a0 100644 --- a/resources/mediawiki.action/mediawiki.action.history.js +++ b/resources/mediawiki.action/mediawiki.action.history.js @@ -20,12 +20,12 @@ jQuery( function( $ ) { // this row has a checked radio button if ( $inputs.get(0).checked ) { - oldLi = $this; + oldLi = true; $this.addClass( 'selected' ); $inputs.eq(0).css( 'visibility', 'visible' ); $inputs.eq(1).css( 'visibility', 'hidden' ); } else if ( $inputs.get(1).checked ) { - diffLi = $this; + diffLi = true; $this.addClass( 'selected' ); $inputs.eq(0).css( 'visibility', 'hidden' ); $inputs.eq(1).css( 'visibility', 'visible' ); @@ -37,8 +37,7 @@ jQuery( function( $ ) { $inputs.eq(1).css( 'visibility', 'hidden' ); } else if ( diffLi ) { // We're between the selected radios - $inputs.eq(0).css( 'visibility', 'visible' ); - $inputs.eq(1).css( 'visibility', 'visible' ); + $inputs.css( 'visibility', 'visible' ); } else { // We're above the selected radios $inputs.eq(1).css( 'visibility', 'visible' ); -- 2.20.1