From 4f6234213f059a68a5170714291c6a8fc4cb7768 Mon Sep 17 00:00:00 2001 From: Kevin Israel Date: Thu, 8 Nov 2012 13:37:06 -0500 Subject: [PATCH] (bug 41899) Fix "Undefined index: start" notice Unsetting the continue param rather than setting it to null results in this PHP error message. Patchset 2: added release note. Change-Id: Ieb6be0ac047d6a4a46fb6522fbbdc058bb386411 --- RELEASE-NOTES-1.21 | 1 + includes/api/ApiQueryRevisions.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.21 b/RELEASE-NOTES-1.21 index 4be260e97b..b9b026cb37 100644 --- a/RELEASE-NOTES-1.21 +++ b/RELEASE-NOTES-1.21 @@ -60,6 +60,7 @@ production. * (bug 26995) Update filename field on Upload page after having sanitized it. * (bug 41793) Contribution links to users with 0 edits on Special:ListUsers didn't show up red. +* (bug 41899) A PHP notice no longer occurs when using the "rvcontinue" API parameter. === API changes in 1.21 === * prop=revisions can now report the contentmodel and contentformat, see docs/contenthandler.txt diff --git a/includes/api/ApiQueryRevisions.php b/includes/api/ApiQueryRevisions.php index 5c3b33be7f..ad40a6486a 100644 --- a/includes/api/ApiQueryRevisions.php +++ b/includes/api/ApiQueryRevisions.php @@ -261,7 +261,7 @@ class ApiQueryRevisions extends ApiQueryBase { // rvstart and rvstartid when that is supplied. if ( !is_null( $params['continue'] ) ) { $params['startid'] = $params['continue']; - unset( $params['start'] ); + $params['start'] = null; } // This code makes an assumption that sorting by rev_id and rev_timestamp produces -- 2.20.1