From 01d04fa014d73f5468ba80ef908b0331deaba662 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Thu, 27 Apr 2017 20:19:32 +0200 Subject: [PATCH] SpecialJavaScriptTest: Do not accidentally pass parameters to QUnit.start() If the mw.loader.using() call's promise is rejected, we end up passing an Error object as the 'count' parameter to QUnit.start(). This seems to be harmless, but is very confusing when debugging. Change-Id: I44caca5285dbced5a5876d9d7ff6236dbd3efc35 --- includes/specials/SpecialJavaScriptTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialJavaScriptTest.php b/includes/specials/SpecialJavaScriptTest.php index 6fbac8a448..52064b79f5 100644 --- a/includes/specials/SpecialJavaScriptTest.php +++ b/includes/specials/SpecialJavaScriptTest.php @@ -140,7 +140,9 @@ class SpecialJavaScriptTest extends SpecialPage { var start = window.__karma__ ? window.__karma__.start : QUnit.start; try { mw.loader.using( $modules ) - .always( start ) + .always( function () { + start(); + } ) .fail( function ( e ) { throw e; } ); } catch ( e ) { start(); -- 2.20.1