From: Abhishek Das <das.abhshk@gmail.com>
Date: Wed, 20 Feb 2013 10:20:28 +0000 (+0530)
Subject: Some minor coding practice fixes;
X-Git-Tag: 1.31.0-rc.0~20639
X-Git-Url: http://git.cyclocoop.org/wiki/Target_page?a=commitdiff_plain;h=c8d221a1e96b69e7c17571215ca7cc4a143b6ae8;p=lhc%2Fweb%2Fwiklou.git

Some minor coding practice fixes;

There were a few lines in `SpecialVersion.php` that caused the build to
be marked as failure. Fixing those:
1. Line 594 - String concat not required, so using single string instead

Change-Id: I799d11aaaf953d09f681585ee23dc5bf496af3d4
---

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index b04f1ef2d1..88d647e92b 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -594,8 +594,7 @@ class SpecialVersion extends SpecialPage {
 	 */
 	private function IPInfo() {
 		$ip = str_replace( '--', ' - ', htmlspecialchars( $this->getRequest()->getIP() ) );
-		return "<!-- visited from $ip -->\n" .
-			"<span style='display:none'>visited from $ip</span>";
+		return "<!-- visited from $ip -->\n<span style='display:none'>visited from $ip</span>";
 	}
 
 	/**