From: Roan Kattouw <catrope@users.mediawiki.org>
Date: Sat, 21 Feb 2009 12:44:41 +0000 (+0000)
Subject: API: Fix up r47470: User::newFromRow() needs all rows from the User table. This kills... 
X-Git-Tag: 1.31.0-rc.0~42745
X-Git-Url: http://git.cyclocoop.org/wiki/Target_page?a=commitdiff_plain;h=9a7d4c9795d4456f82dbcedc56533c75ed4b633a;p=lhc%2Fweb%2Fwiklou.git

API: Fix up r47470: User::newFromRow() needs all rows from the User table. This kills lots of warnings and really fixes bug 17561
---

diff --git a/includes/api/ApiQueryUsers.php b/includes/api/ApiQueryUsers.php
index 6e0e5c5357..3efd4e0889 100644
--- a/includes/api/ApiQueryUsers.php
+++ b/includes/api/ApiQueryUsers.php
@@ -78,10 +78,8 @@ if (!defined('MEDIAWIKI')) {
 		{
 			$db = $this->getDb();
 			$this->addTables('user', 'u1');
-			$this->addFields('u1.user_name');
+			$this->addFields('u1.*');
 			$this->addWhereFld('u1.user_name', $goodNames);
-			$this->addFieldsIf('u1.user_editcount', isset($this->prop['editcount']));
-			$this->addFieldsIf('u1.user_registration', isset($this->prop['registration']));
 
 			if(isset($this->prop['groups'])) {
 				$this->addTables('user_groups');