From 5267844eea035669aa3c2e597a468e6b9ee44fb2 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Tue, 28 May 2019 20:10:48 +0200 Subject: [PATCH] mediawiki.action.view.dblClickEdit: Move preventDefault() Move the preventDefault() into the if-condition to trigger the preventDefault() only together with the click() trigger. Change-Id: Icde2187248b8b18cd4fd5085a92d840e1f77b00d --- .../src/mediawiki.action/mediawiki.action.view.dblClickEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js index dbf029e3c2..7b7c70d6cf 100644 --- a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js +++ b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js @@ -7,11 +7,11 @@ var $a; // Recheck preference so extensions can do a hack to disable this code. if ( parseInt( mw.user.options.get( 'editondblclick' ), 10 ) ) { - e.preventDefault(); // Trigger native HTMLElement click instead of opening URL (T45052) $a = $( '#ca-edit a' ); // Not every page has an edit link (T59713) if ( $a.length ) { + e.preventDefault(); // eslint-disable-next-line no-jquery/no-event-shorthand $a.get( 0 ).click(); } -- 2.20.1